diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2014-04-02 10:55:03 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-04-02 21:43:11 +0000 |
| commit | 2cd8a20204409b0acb4083c530a58d1ee0a1cac0 (patch) | |
| tree | 81749690bef6da47443edab7d258bf785dda2564 | |
| parent | 5dbff5487aeb9fc005e759e8f7c07b4b4eea2780 (diff) | |
| download | chrome-ec-2cd8a20204409b0acb4083c530a58d1ee0a1cac0.tar.gz | |
Samus: LIGHTBAR_RESET_L should be open-drain.
This GPIO was configured as TTL. It should be open drain instead.
BUG=chrome-os-partner:27280
BRANCH=ToT
TEST=manual
Hard reboot, lightbar still works.
Try turning it off and on from the EC console:
> gpioset LIGHTBAR_RESET_L 0
lightbar goes dark.
> gpioset LIGHTBAR_RESET_L 1
> lightbar init
> lightbar on
lightbar comes on again.
Change-Id: If4d4beade8c95f3f231eeed435e35350ce866cea
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/192871
Reviewed-by: Randall Spangler <rspangler@chromium.org>
| -rw-r--r-- | board/samus/board.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board/samus/board.c b/board/samus/board.c index 9e203c19da..ba1f42e8ad 100644 --- a/board/samus/board.c +++ b/board/samus/board.c @@ -106,7 +106,7 @@ const struct gpio_info gpio_list[] = { {"ENABLE_BACKLIGHT", LM4_GPIO_M, (1<<7), GPIO_OUT_LOW, NULL}, {"ENABLE_TOUCHPAD", LM4_GPIO_N, (1<<1), GPIO_OUT_LOW, NULL}, {"ENTERING_RW", LM4_GPIO_D, (1<<3), GPIO_OUT_LOW, NULL}, - {"LIGHTBAR_RESET_L", LM4_GPIO_J, (1<<2), GPIO_OUT_LOW, NULL}, + {"LIGHTBAR_RESET_L", LM4_GPIO_J, (1<<2), GPIO_ODR_LOW, NULL}, {"PCH_DPWROK", LM4_GPIO_G, (1<<0), GPIO_OUT_LOW, NULL}, /* * HDA_SDO is technically an output, but we need to leave it as an |