diff options
| author | Randall Spangler <rspangler@chromium.org> | 2013-12-16 12:45:01 -0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2013-12-16 22:57:34 +0000 |
| commit | c450c2b2202cb3d835a0d8d709b5182c96c92c88 (patch) | |
| tree | 789da38013a6266606b5625e3ad28662cf830263 | |
| parent | 400d7758bd4dbf705611c2cab3ba0da2f4b292fa (diff) | |
| download | chrome-ec-c450c2b2202cb3d835a0d8d709b5182c96c92c88.tar.gz | |
rambi: Invert SOC_OVERRIDE signal
SOC_OVERRIDE now drives a FET, so the signal is inverted (high=active,
not low). EC must drive it push-pull because there is no
pullup/pulldown on the input to the FET.
BUG=chrome-os-partner:24118
BRANCH=none
TEST='gpioget' shows signal is 0 by default, not 1.
Change-Id: I8a86587c7fad8bf5a583cd3976bd6ed3069f2975
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/180287
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
| -rw-r--r-- | board/rambi/board.c | 2 | ||||
| -rw-r--r-- | board/rambi/board.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/board/rambi/board.c b/board/rambi/board.c index 2213ee224c..6883395b7b 100644 --- a/board/rambi/board.c +++ b/board/rambi/board.c @@ -88,7 +88,7 @@ const struct gpio_info gpio_list[] = { {"PCH_RCIN_L", LM4_GPIO_F, (1<<3), GPIO_ODR_HIGH, NULL}, {"PCH_RSMRST_L", LM4_GPIO_F, (1<<1), GPIO_OUT_LOW, NULL}, {"PCH_SMI_L", LM4_GPIO_F, (1<<4), GPIO_ODR_HIGH, NULL}, - {"PCH_SOC_OVERRIDE_L", LM4_GPIO_G, (1<<1), GPIO_OUT_HIGH, NULL}, + {"PCH_SOC_OVERRIDE", LM4_GPIO_G, (1<<1), GPIO_OUT_LOW, NULL}, /* * TODO(crosbug.com/p/24424): Remove old assignment and remove _NEW * from the new one when we deprecate the 1.5 boards. diff --git a/board/rambi/board.h b/board/rambi/board.h index 37b54cc04c..0ce41870f4 100644 --- a/board/rambi/board.h +++ b/board/rambi/board.h @@ -97,7 +97,7 @@ enum gpio_signal { GPIO_PCH_RCIN_L, /* Reset line to PCH (for 8042 emulation) */ GPIO_PCH_RSMRST_L, /* Reset PCH resume power plane logic */ GPIO_PCH_SMI_L, /* System management interrupt to PCH */ - GPIO_PCH_SOC_OVERRIDE_L, /* SOC override signal to PCH; when high, ME + GPIO_PCH_SOC_OVERRIDE, /* SOC override signal to PCH; when high, ME * ignores security descriptor */ /* * TODO(crosbug.com/p/24424): Remove old assignment and remove _NEW |