diff options
| author | Vic (Chun-Ju) Yang <victoryang@chromium.org> | 2013-12-09 15:51:26 +0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2013-12-10 04:40:39 +0000 |
| commit | 6f348ecf083a3182b7eed83cdd9a9bc19751a0ba (patch) | |
| tree | cf26cf7ccbfe525abb4074b6743b2c0fcad73b98 | |
| parent | 1d24f4d661473223fd5eaf60a62ec0f1068d58f2 (diff) | |
| download | chrome-ec-6f348ecf083a3182b7eed83cdd9a9bc19751a0ba.tar.gz | |
Remove unneeded TODO comment
When we are detecting Apple charger type, we disable TSU6721 interrupt.
This, however, doesn't create a race condition, because any pending
interrupt fires immediately after we re-enable TSU6721 interrupt, and in
turns schedules charger task. As a result, charger task gets waken right
after it finishes its current iteration.
As for overcurrent detection, the current algorithm seems to do a good
enough job.
BUG=chrome-os-partner:23743, chrome-os-partner:23744
TEST=None
BRANCH=None
Change-Id: Ib3a6d562a305020ef5413e2a493e4163a6e70954
Signed-off-by: Vic (Chun-Ju) Yang <victoryang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/179303
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
| -rw-r--r-- | common/extpower_spring.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/common/extpower_spring.c b/common/extpower_spring.c index 2e11e30d47..3be307bc7e 100644 --- a/common/extpower_spring.c +++ b/common/extpower_spring.c @@ -236,7 +236,6 @@ static int apple_charger_current(void) int type = 0; int data[ADC_CH_COUNT]; - /* TODO(crosbug.com/p/23743): Handle potential race condition. */ tsu6721_disable_interrupts(); tsu6721_mux(TSU6721_MUX_USB); /* Wait for signal to stablize */ @@ -453,10 +452,6 @@ static void usb_detect_overcurrent(int dev_type) int idx = !(current_dev_type == TSU6721_TYPE_VBUS_DEBOUNCED); power_removed_time[idx] = get_time(); power_removed_type[idx] = current_dev_type; - /* - * TODO(crosbug.com/p/23744): Record the maximum current seen - * during retry? - */ power_removed_pwm_duty[idx] = current_pwm_duty; } else if (dev_type & TSU6721_TYPE_VBUS_DEBOUNCED) { int idx = !(dev_type == TSU6721_TYPE_VBUS_DEBOUNCED); |