summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRandall Spangler <rspangler@chromium.org>2013-09-11 16:18:50 -0700
committerchrome-internal-fetch <chrome-internal-fetch@google.com>2013-09-13 23:23:48 +0000
commit40f4d61266192f2ec439c943be7a945232efd388 (patch)
tree5bfa91bb3ec23da44134ac1af23ad92aae6cf198
parent6bfeb498552ea7f6f4dcbb670f291fd8c50e29bd (diff)
downloadchrome-ec-40f4d61266192f2ec439c943be7a945232efd388.tar.gz
Remove unused uart functions
Nothing ever called uart_flush_input() or uart_gets(), so remove them. They're dead code, and make implementing UART DMA input more complex. BUG=chrome-os-partner:20485 BRANCH=none TEST=build all platforms; pass unit tests Change-Id: I94c2c372ac3f326b98e819b2c89b8995311b2868 Signed-off-by: Randall Spangler <rspangler@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/169345 Reviewed-by: Bill Richardson <wfrichar@chromium.org>
-rw-r--r--common/uart_buffering.c42
-rw-r--r--include/uart.h26
2 files changed, 0 insertions, 68 deletions
diff --git a/common/uart_buffering.c b/common/uart_buffering.c
index 3a55d10631..784e117503 100644
--- a/common/uart_buffering.c
+++ b/common/uart_buffering.c
@@ -240,21 +240,6 @@ void uart_flush_output(void)
uart_tx_flush();
}
-void uart_flush_input(void)
-{
- /* Disable interrupts */
- uart_disable_interrupt();
-
- /* Empty the hardware FIFO */
- uart_process_input();
-
- /* Clear the input buffer */
- rx_buf_tail = rx_buf_head;
-
- /* Re-enable interrupts */
- uart_enable_interrupt();
-}
-
int uart_getc(void)
{
int c;
@@ -278,33 +263,6 @@ int uart_getc(void)
return c;
}
-int uart_gets(char *dest, int size)
-{
- int got = 0;
- int c;
-
- /* Read characters */
- while (got < size - 1) {
- c = uart_getc();
-
- /* Stop on input buffer empty */
- if (c == -1)
- break;
-
- dest[got++] = c;
-
- /* Stop after newline */
- if (c == '\n')
- break;
- }
-
- /* Null-terminate */
- dest[got] = '\0';
-
- /* Return the length we got */
- return got;
-}
-
/*****************************************************************************/
/* Host commands */
diff --git a/include/uart.h b/include/uart.h
index fec3fd47ec..bada502c8b 100644
--- a/include/uart.h
+++ b/include/uart.h
@@ -80,38 +80,12 @@ void uart_flush_output(void);
*/
/**
- * Flush input buffer, discarding all input.
- */
-void uart_flush_input(void);
-
-/**
* Read a single character of input, similar to fgetc().
*
* @return the character, or -1 if no input waiting.
*/
int uart_getc(void);
-/**
- * Read characters from the UART, similar to fgets().
- *
- * Reads input until one of the following conditions is met:
- * (1) <size-1> characters have been read.
- * (2) A newline ('\n') has been read.
- * (3) The input buffer is empty (this keeps the call from blocking).
- *
- * Characters are stored in <dest> and are null-terminated.
- * Characters include the newline if present, so that the caller can
- * distinguish between a complete line and a truncated one. If the
- * input buffer is empty, a null-terminated empty string ("") is
- * returned.
- *
- * @param dest Destination for input
- * @param size Size of buffer pointed to by dest
- *
- * @return the number of characters read, not counting the terminating null.
- */
-int uart_gets(char *dest, int size);
-
/*
* Hardware UART driver functions
*/