diff options
| author | Diana Z <dzigterman@chromium.org> | 2023-02-22 14:53:07 -0700 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-02-23 22:01:26 +0000 |
| commit | 2444aa135973716b25fed01e0b5163a932643617 (patch) | |
| tree | 61c7cf3fe51de4c1ede14c70710f561c071acba4 | |
| parent | 751281d05b36c0432fed4a0dfd17febdc8ef927c (diff) | |
| download | chrome-ec-2444aa135973716b25fed01e0b5163a932643617.tar.gz | |
TCPM: Correct mfallow error returns
The mfallow command returns the incorrect errors for parameters being
wrong.
BRANCH=None
BUG=None
TEST=zephyr mfallow console command test
Change-Id: I475cc8283d6bb926dd330d7434af5d7d84f21979
Signed-off-by: Diana Z <dzigterman@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4283689
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
| -rw-r--r-- | common/usb_pd_policy.c | 4 | ||||
| -rw-r--r-- | common/usbc/dp_alt_mode.c | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/common/usb_pd_policy.c b/common/usb_pd_policy.c index 38cfd226d2..28d3d4f5d3 100644 --- a/common/usb_pd_policy.c +++ b/common/usb_pd_policy.c @@ -1224,14 +1224,14 @@ static int command_mfallow(int argc, const char **argv) port = strtoi(argv[1], &e, 10); if (*e || port >= board_get_usb_pd_port_count()) - return EC_ERROR_PARAM2; + return EC_ERROR_PARAM1; if (!strcasecmp(argv[2], "true")) dp_port_mf_allow[port] = true; else if (!strcasecmp(argv[2], "false")) dp_port_mf_allow[port] = false; else - return EC_ERROR_PARAM1; + return EC_ERROR_PARAM2; ccprintf("Port: %d multi function allowed is %s ", port, argv[2]); return EC_SUCCESS; diff --git a/common/usbc/dp_alt_mode.c b/common/usbc/dp_alt_mode.c index 7ece3573a8..da6564f692 100644 --- a/common/usbc/dp_alt_mode.c +++ b/common/usbc/dp_alt_mode.c @@ -700,14 +700,14 @@ static int command_mfallow(int argc, const char **argv) port = strtoi(argv[1], &e, 10); if (*e || port >= board_get_usb_pd_port_count()) - return EC_ERROR_PARAM2; + return EC_ERROR_PARAM1; if (!strcasecmp(argv[2], "true")) dp_port_mf_allow[port] = true; else if (!strcasecmp(argv[2], "false")) dp_port_mf_allow[port] = false; else - return EC_ERROR_PARAM1; + return EC_ERROR_PARAM2; ccprintf("Port: %d multi function allowed is %s ", port, argv[2]); return EC_SUCCESS; |