diff options
| author | Leila Lin <leilacy_lin@compal.corp-partner.google.com> | 2022-12-23 15:34:25 +0800 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-12-24 03:25:07 +0000 |
| commit | 269355cc3b5f06058b0be458c7276367cd96eeed (patch) | |
| tree | 977045f56705e61350eff59bae1d45e8001ebb7a | |
| parent | 5b6a2bf83049902633c3c0e9e2178e2628f0fb1c (diff) | |
| download | chrome-ec-269355cc3b5f06058b0be458c7276367cd96eeed.tar.gz | |
Winterhold: Modify thermal config
Use soc and amb sensor to control fan.
Modify thermal config.
LOW_COVERAGE_REASON=no unit tests for skyrim yet, b/247151116
BUG=b:255732503
BRANCH=none
TEST=verify the thermal config on winterhold is correct
Change-Id: I4a0ec0510998d9bd7623fd1c1ff86d158ff424df
Signed-off-by: Leila Lin <leilacy_lin@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4113512
Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
Reviewed-by: Chao Gui <chaogui@google.com>
Commit-Queue: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com>
Tested-by: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| -rw-r--r-- | zephyr/program/skyrim/winterhold/project.overlay | 6 | ||||
| -rw-r--r-- | zephyr/program/skyrim/winterhold/src/thermal.c | 18 |
2 files changed, 10 insertions, 14 deletions
diff --git a/zephyr/program/skyrim/winterhold/project.overlay b/zephyr/program/skyrim/winterhold/project.overlay index 12001200cc..9a4733a790 100644 --- a/zephyr/program/skyrim/winterhold/project.overlay +++ b/zephyr/program/skyrim/winterhold/project.overlay @@ -58,6 +58,8 @@ temp_host_halt = <110>; temp_host_release_high = <95>; temp_host_release_halt = <100>; + temp_fan_off = <42>; + temp_fan_max = <70>; power-good-pin = <&gpio_pg_pwr_s5>; sensor = <&soc_pct2075>; }; @@ -193,8 +195,8 @@ /delete-property/ temp_host_high; /delete-property/ temp_host_halt; /delete-property/ temp_host_release_high; - /delete-property/ temp_fan_off; - /delete-property/ temp_fan_max; + temp_fan_off = <54>; + temp_fan_max = <67>; }; /* handler overrides */ diff --git a/zephyr/program/skyrim/winterhold/src/thermal.c b/zephyr/program/skyrim/winterhold/src/thermal.c index 9f4b8465f4..dcc0562fff 100644 --- a/zephyr/program/skyrim/winterhold/src/thermal.c +++ b/zephyr/program/skyrim/winterhold/src/thermal.c @@ -21,17 +21,15 @@ #define THERMAL_DESKTOP_LID_OPEN \ { \ .temp_host = { \ - [EC_TEMP_THRESH_WARN] = C_TO_K(50), \ + [EC_TEMP_THRESH_WARN] = C_TO_K(44), \ [EC_TEMP_THRESH_HIGH] = C_TO_K(105), \ [EC_TEMP_THRESH_HALT] = C_TO_K(110), \ }, \ .temp_host_release = { \ - [EC_TEMP_THRESH_WARN] = C_TO_K(45), \ + [EC_TEMP_THRESH_WARN] = C_TO_K(40), \ [EC_TEMP_THRESH_HIGH] = C_TO_K(95), \ [EC_TEMP_THRESH_HALT] = C_TO_K(100), \ }, \ - .temp_fan_off = C_TO_K(31), \ - .temp_fan_max = C_TO_K(38), \ } __maybe_unused static const struct ec_thermal_config thermal_desktop_lid_open = THERMAL_DESKTOP_LID_OPEN; @@ -42,17 +40,15 @@ __maybe_unused static const struct ec_thermal_config thermal_desktop_lid_open = #define THERMAL_DESKTOP_LID_CLOSE \ { \ .temp_host = { \ - [EC_TEMP_THRESH_WARN] = C_TO_K(55), \ + [EC_TEMP_THRESH_WARN] = C_TO_K(43), \ [EC_TEMP_THRESH_HIGH] = C_TO_K(105), \ [EC_TEMP_THRESH_HALT] = C_TO_K(110), \ }, \ .temp_host_release = { \ - [EC_TEMP_THRESH_WARN] = C_TO_K(50), \ + [EC_TEMP_THRESH_WARN] = C_TO_K(39), \ [EC_TEMP_THRESH_HIGH] = C_TO_K(95), \ [EC_TEMP_THRESH_HALT] = C_TO_K(100), \ - }, \ - .temp_fan_off = C_TO_K(32), \ - .temp_fan_max = C_TO_K(39), \ + }, \ } __maybe_unused static const struct ec_thermal_config thermal_desktop_lid_close = THERMAL_DESKTOP_LID_CLOSE; @@ -63,7 +59,7 @@ __maybe_unused static const struct ec_thermal_config thermal_desktop_lid_close = #define THERMAL_LAPTOP \ { \ .temp_host = { \ - [EC_TEMP_THRESH_WARN] = C_TO_K(45), \ + [EC_TEMP_THRESH_WARN] = C_TO_K(44), \ [EC_TEMP_THRESH_HIGH] = C_TO_K(105), \ [EC_TEMP_THRESH_HALT] = C_TO_K(110), \ }, \ @@ -72,8 +68,6 @@ __maybe_unused static const struct ec_thermal_config thermal_desktop_lid_close = [EC_TEMP_THRESH_HIGH] = C_TO_K(95), \ [EC_TEMP_THRESH_HALT] = C_TO_K(100), \ }, \ - .temp_fan_off = C_TO_K(30), \ - .temp_fan_max = C_TO_K(38), \ } __maybe_unused static const struct ec_thermal_config thermal_laptop = THERMAL_LAPTOP; |