summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZick Wei <zick.wei@quanta.corp-partner.google.com>2021-09-07 10:15:33 +0800
committerCommit Bot <commit-bot@chromium.org>2021-09-29 14:44:27 +0000
commitb8d85657b9eb79b4d73142022bf6f284621cc0c3 (patch)
treed4a8b658e6e64dd03435b7cbe41f557c5ea01e06
parentb521e788b84c20810ce4cbffbd83cd12575e3ece (diff)
downloadchrome-ec-b8d85657b9eb79b4d73142022bf6f284621cc0c3.tar.gz
nipperkin: update fw_config field
Update cbi fw_config field follow b:196909635 BUG=b:196909635 BRANCH=none TEST=make BOARD=nipperkin Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I877b0b7db788680f513686100ad3d5f5e6d59b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3144411 Reviewed-by: Rob Barnes <robbarnes@google.com> Commit-Queue: Rob Barnes <robbarnes@google.com>
-rw-r--r--board/nipperkin/board_fw_config.c14
-rw-r--r--board/nipperkin/board_fw_config.h34
2 files changed, 23 insertions, 25 deletions
diff --git a/board/nipperkin/board_fw_config.c b/board/nipperkin/board_fw_config.c
index 82b291e639..c9fa01bc7a 100644
--- a/board/nipperkin/board_fw_config.c
+++ b/board/nipperkin/board_fw_config.c
@@ -6,13 +6,6 @@
#include "base_fw_config.h"
#include "board_fw_config.h"
-bool board_is_convertible(void)
-{
- return (get_fw_config_field(FW_CONFIG_FORM_FACTOR_OFFSET,
- FW_CONFIG_FORM_FACTOR_WIDTH)
- == FW_CONFIG_FORM_FACTOR_CONVERTIBLE);
-}
-
bool board_has_kblight(void)
{
return (get_fw_config_field(FW_CONFIG_KBLIGHT_OFFSET,
@@ -28,3 +21,10 @@ enum board_usb_a1_retimer board_get_usb_a1_retimer(void)
{
return USB_A1_RETIMER_PS8811;
};
+
+bool board_has_privacy_panel(void)
+{
+ return (get_fw_config_field(FW_CONFIG_KEYBOARD_OFFSET,
+ FW_CONFIG_KEYBOARD_WIDTH) ==
+ FW_CONFIG_KEYBOARD_PRIVACY_YES);
+}
diff --git a/board/nipperkin/board_fw_config.h b/board/nipperkin/board_fw_config.h
index 1dbb510965..77306ccb6f 100644
--- a/board/nipperkin/board_fw_config.h
+++ b/board/nipperkin/board_fw_config.h
@@ -3,35 +3,33 @@
* found in the LICENSE file.
*/
-#ifndef _GUYBRUSH_BOARD_FW_CONFIG__H_
-#define _GUYBRUSH_BOARD_FW_CONFIG__H_
+#ifndef _NIPPERKIN_BOARD_FW_CONFIG__H_
+#define _NIPPERKIN_BOARD_FW_CONFIG__H_
/****************************************************************************
- * Guybrush CBI FW Configuration
+ * Nipperkin CBI FW Configuration
*/
/*
- * USB Daughter Board (2 bits)
+ * Keyboard Backlight (1 bit)
*/
-#define FW_CONFIG_USB_DB_OFFSET 0
-#define FW_CONFIG_USB_DB_WIDTH 2
-#define FW_CONFIG_USB_DB_A1_PS8811_C1_PS8818 0
+#define FW_CONFIG_KBLIGHT_OFFSET 0
+#define FW_CONFIG_KBLIGHT_WIDTH 1
+#define FW_CONFIG_KBLIGHT_NO 0
+#define FW_CONFIG_KBLIGHT_YES 1
/*
- * Form Factor (1 bits)
+ * Bit 1 ~ 6 not related to EC function
*/
-#define FW_CONFIG_FORM_FACTOR_OFFSET 2
-#define FW_CONFIG_FORM_FACTOR_WIDTH 1
-#define FW_CONFIG_FORM_FACTOR_CLAMSHELL 0
-#define FW_CONFIG_FORM_FACTOR_CONVERTIBLE 1
/*
- * Keyboard Backlight (1 bit)
+ * Keyboard (1 bit)
*/
-#define FW_CONFIG_KBLIGHT_OFFSET 3
-#define FW_CONFIG_KBLIGHT_WIDTH 1
-#define FW_CONFIG_KBLIGHT_NO 0
-#define FW_CONFIG_KBLIGHT_YES 1
+#define FW_CONFIG_KEYBOARD_OFFSET 7
+#define FW_CONFIG_KEYBOARD_WIDTH 1
+#define FW_CONFIG_KEYBOARD_PRIVACY_YES 0
+#define FW_CONFIG_KEYBOARD_PRIVACY_NO 1
+bool board_has_privacy_panel(void);
-#endif /* _GUYBRUSH_CBI_FW_CONFIG__H_ */
+#endif /* _NIPPERKIN_BOARD_FW_CONFIG__H_ */