diff options
| author | Craig Hesling <hesling@chromium.org> | 2022-10-06 20:51:23 -0400 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-10-11 17:39:13 +0000 |
| commit | c9d0c97a9fa59ff1ab113e5d56753a1c666e33d5 (patch) | |
| tree | 9f534c69122d4712802d153eb9cc46396747a0aa | |
| parent | 5bcd282988e01f335385ae5969d4cd942a83cee3 (diff) | |
| download | chrome-ec-c9d0c97a9fa59ff1ab113e5d56753a1c666e33d5.tar.gz | |
third_party: Fix print-tests for cryptoc users
The use of this variable collides with another use of the variable.
Since cryptoc was introduced, the print-tests target wouldn't work
correctly for boards that used cryptoc. Instead of printing the
test target symbolic name, it would print the full path to all test
executable targets.
BRANCH=none
BUG=b:169156874,b:236389226,b:176500425
TEST=make BOARD=bloonchipper print-tests
# Check that the full path isn't shown
TEST=make BOARD=bloonchipper tests
# Ensure that cryptoc is being built for tests
TEST=make host-fp
# Ensure cryptoc is being built
TEST=make BOARD=bloonchipper
# Ensure cryptoc is being built
TEST=./util/compare_build.sh -bfp
# verdict was match
Change-Id: Ia0c0aa9b57c224395df6e2e5551fbc71b7db00fa
Signed-off-by: Craig Hesling <hesling@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3937046
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
| -rw-r--r-- | third_party/rules.mk | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/third_party/rules.mk b/third_party/rules.mk index eb4391b70c..57707d87dd 100644 --- a/third_party/rules.mk +++ b/third_party/rules.mk @@ -49,9 +49,9 @@ $(out)/RW/ec.RW.elf $(out)/RW/ec.RW_B.elf: $(out)/cryptoc/libcryptoc.a $(out)/$(PROJECT).exe: LDFLAGS_EXTRA += $(CRYPTOC_LDFLAGS) $(out)/$(PROJECT).exe: $(out)/cryptoc/libcryptoc.a # On-device tests. -test-targets=$(foreach test,$(test-list-y),\ +third-party-test-targets=$(foreach test,$(test-list-y),\ $(out)/RW/$(test).RW.elf $(out)/RO/$(test).RO.elf) -$(test-targets): LDFLAGS_EXTRA += $(CRYPTOC_LDFLAGS) -$(test-targets): $(out)/cryptoc/libcryptoc.a +$(third-party-test-targets): LDFLAGS_EXTRA += $(CRYPTOC_LDFLAGS) +$(third-party-test-targets): $(out)/cryptoc/libcryptoc.a endif # CONFIG_LIBCRYPTOC |