diff options
| author | Tom Hughes <tomhughes@chromium.org> | 2022-08-26 10:24:04 -0700 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-08-27 00:05:13 +0000 |
| commit | d3df48ec61fbd9009305cfbfd4e8865388b94d47 (patch) | |
| tree | 2be66ca78f97bde5510f58b91a49e104278e648b | |
| parent | 9e53c395539c969c52b7a7463148f8ac0ceb5e43 (diff) | |
| download | chrome-ec-d3df48ec61fbd9009305cfbfd4e8865388b94d47.tar.gz | |
util/flash_ec: Fix shellcheck warnings
if [ -n "${FLAGS_chip}" -a "${CHIP}" != "${FLAGS_chip}" ]; then
^-- SC2166: Prefer [ p ] && [ q ] as [ p -a q ]
is not well defined.
BRANCH=none
BUG=b:242127759
TEST=./util/flash_ec --board=dartmonkey
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I08a190373cfd9e10b395d700f4bca99da761609b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3860067
Reviewed-by: Andrea Grandi <agrandi@google.com>
| -rwxr-xr-x | util/flash_ec | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/util/flash_ec b/util/flash_ec index 6d00ed122a..cba92b3c2f 100755 --- a/util/flash_ec +++ b/util/flash_ec @@ -359,7 +359,7 @@ else "(${FILTERED_CHIPS[@]}). Use --chip= to choose one." fi -if [ -n "${FLAGS_chip}" -a "${CHIP}" != "${FLAGS_chip}" ]; then +if [ -n "${FLAGS_chip}" ] && [ "${CHIP}" != "${FLAGS_chip}" ]; then die "board ${BOARD} doesn't use chip ${FLAGS_chip}" fi @@ -658,7 +658,7 @@ cleanup() { servo_restore - if [ "${CHIP}" = "stm32" -o "${CHIP}" = "npcx_uut" ]; then + if [ "${CHIP}" = "stm32" ] || [ "${CHIP}" = "npcx_uut" ]; then dut_control "${MCU}"_boot_mode:off fi |