diff options
| author | Tom Hughes <tomhughes@chromium.org> | 2022-08-26 10:37:02 -0700 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-08-27 00:05:40 +0000 |
| commit | 671eb33f3c33932fc9a2362ff13f495df76fe593 (patch) | |
| tree | 9c0c1bc0c5a203ffb01ee6c13cc583a62e8a255b | |
| parent | c59cae82ecceeb3b37dca44fbe85aefeb84d9d8b (diff) | |
| download | chrome-ec-671eb33f3c33932fc9a2362ff13f495df76fe593.tar.gz | |
util/flash_ec: Fix shellcheck warnings
"UART baud rate to use when bit bang programming, "\
^-- SC2140: Word is
of the form "A"B"C" (B indicated). Did
you mean "ABC" or "A\"B\"C"?
for p in $@ ; do
^-- SC2068: Double quote array expansions to avoid re-splitting elements.
BRANCH=none
BUG=b:242127759
TEST=./util/flash_ec --board=dartmonkey
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I20b517627bd3b6e216e87593309b78aeb27a49c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3860071
Reviewed-by: Andrea Grandi <agrandi@google.com>
| -rwxr-xr-x | util/flash_ec | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/util/flash_ec b/util/flash_ec index b1e4ca00c4..18c13ee87a 100755 --- a/util/flash_ec +++ b/util/flash_ec @@ -147,7 +147,7 @@ BITBANG_RATE="57600" # Could be overwritten by a command line option. # Flags DEFINE_integer bitbang_rate "${BITBANG_RATE}" \ - "UART baud rate to use when bit bang programming, "\ + "UART baud rate to use when bit bang programming, " \ "standard UART rates from 9600 to 57600 are supported." DEFINE_string board "${DEFAULT_BOARD}" \ "The board to run debugger on." @@ -223,7 +223,7 @@ function print_or_run() { function dut_control() { local DUT_CTRL_CML=( "${DUT_CONTROL_CMD[@]}" ) - for p in $@ ; do + for p in "$@" ; do # Only add the prefix if the arg is a control name. if [[ ${p} != -* ]] ; then p="${DUT_CTRL_PREFIX}${p}" |