diff options
| author | ben chen <ben.chen2@quanta.corp-partner.google.com> | 2022-07-26 17:37:56 +0800 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-08-02 00:47:16 +0000 |
| commit | f84f681414612df414843b860843aa6116f3e9d1 (patch) | |
| tree | a8291676aa230313e4971681b10848d46058c682 | |
| parent | d0e12f8e600b701d376e9861922102b5692b3a5b (diff) | |
| download | chrome-ec-f84f681414612df414843b860843aa6116f3e9d1.tar.gz | |
kuldax: update thermal Fan table
Update thermal Fan table
BUG=b:238260272
BRANCH=cros/main
TEST=build BOARD PASS and thermal check is PASS.
Change-Id: I03cd8d2ba59e9cd2a15aa9cffb402300f3f20537
Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3787656
Reviewed-by: Boris Mittelberg <bmbm@google.com>
| -rw-r--r-- | board/kuldax/fans.c | 6 | ||||
| -rw-r--r-- | board/kuldax/sensors.c | 41 |
2 files changed, 25 insertions, 22 deletions
diff --git a/board/kuldax/fans.c b/board/kuldax/fans.c index 62492fe063..89ed0f90bc 100644 --- a/board/kuldax/fans.c +++ b/board/kuldax/fans.c @@ -37,9 +37,9 @@ static const struct fan_conf fan_conf_0 = { * Set minimum at around 30% PWM. */ static const struct fan_rpm fan_rpm_0 = { - .rpm_min = 2200, - .rpm_start = 2200, - .rpm_max = 7200, + .rpm_min = 2400, + .rpm_start = 2400, + .rpm_max = 4500, }; const struct fan_t fans[FAN_CH_COUNT] = { diff --git a/board/kuldax/sensors.c b/board/kuldax/sensors.c index 0f91d47f3b..ac9f5f9971 100644 --- a/board/kuldax/sensors.c +++ b/board/kuldax/sensors.c @@ -78,37 +78,40 @@ const struct temp_sensor_t temp_sensors[] = { BUILD_ASSERT(ARRAY_SIZE(temp_sensors) == TEMP_SENSOR_COUNT); /* - * TODO(b/180681346): update for Alder Lake/brya - * - * Tiger Lake specifies 100 C as maximum TDP temperature. THRMTRIP# occurs at - * 130 C. However, sensor is located next to DDR, so we need to use the lower - * DDR temperature limit (85 C) - */ -/* - * TODO(b/202062363): Remove when clang is fixed. + * TODO(b/238260272): add the thermal sensor setting */ #define THERMAL_CPU \ { \ .temp_host = { \ - [EC_TEMP_THRESH_HIGH] = C_TO_K(70), \ - [EC_TEMP_THRESH_HALT] = C_TO_K(80), \ + [EC_TEMP_THRESH_HIGH] = C_TO_K(75), \ + [EC_TEMP_THRESH_HALT] = C_TO_K(90), \ }, \ .temp_host_release = { \ - [EC_TEMP_THRESH_HIGH] = C_TO_K(65), \ + [EC_TEMP_THRESH_HALT] = C_TO_K(70), \ }, \ .temp_fan_off = C_TO_K(35), \ - .temp_fan_max = C_TO_K(50), \ + .temp_fan_max = C_TO_K(89), \ } __maybe_unused static const struct ec_thermal_config thermal_cpu = THERMAL_CPU; -/* - * TODO(b/197478860): add the thermal sensor setting - */ -/* this should really be "const" */ +#define THERMAL_FAN \ + { \ + .temp_host = { \ + [EC_TEMP_THRESH_HIGH] = 0, \ + [EC_TEMP_THRESH_HALT] = 0, \ + }, \ + .temp_host_release = { \ + [EC_TEMP_THRESH_HIGH] = 0, \ + }, \ + .temp_fan_off = 0, \ + .temp_fan_max = 0, \ + } +__maybe_unused static const struct ec_thermal_config thermal_fan = THERMAL_FAN; + struct ec_thermal_config thermal_params[] = { [TEMP_SENSOR_1_CPU] = THERMAL_CPU, - [TEMP_SENSOR_2_CPU_VR] = THERMAL_CPU, - [TEMP_SENSOR_3_WIFI] = THERMAL_CPU, - [TEMP_SENSOR_4_DIMM] = THERMAL_CPU, + [TEMP_SENSOR_2_CPU_VR] = THERMAL_FAN, + [TEMP_SENSOR_3_WIFI] = THERMAL_FAN, + [TEMP_SENSOR_4_DIMM] = THERMAL_FAN, }; BUILD_ASSERT(ARRAY_SIZE(thermal_params) == TEMP_SENSOR_COUNT); |