diff options
| author | Mary Ruthven <mruthven@chromium.org> | 2022-01-14 16:43:27 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2022-01-25 18:24:17 +0000 |
| commit | c932c5a34f01a8c7ed516a91a4be7ed060390f0e (patch) | |
| tree | cebcdd68dc3fcd6c5a806cb04b115e820e1663ce | |
| parent | 679179d7ac5d0ec062b33535b7607e48856b570a (diff) | |
| download | chrome-ec-c932c5a34f01a8c7ed516a91a4be7ed060390f0e.tar.gz | |
cr50: make strap errors louder
Add "ERROR" and some exclamation points to make invalid strap messages
more noticeable.
BUG=b:214550629
TEST=look at invalid strap error messages on red board.
strap pin readings: a1:3 a9:1 a6:1 a12:3
[0.005569 WARN Ambiguous strap cfg. Use spi based on old brdprop.]
[0.006675 get_properties: ERROR NO TABLE ENTRY!!! cfg: 0x7 prop: 0x1]
strap pin readings: a1:3 a9:1 a6:1 a12:3
[0.005649 get_properties: ERROR INVALID STRAP PINS!!! cfg 0xd7 prop 0x42
Change-Id: Ie1e29fd4152a2b3f984989e37b771339895e6a0e
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3390071
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
| -rw-r--r-- | board/cr50/board.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/board/cr50/board.c b/board/cr50/board.c index ea90392005..4f0ea7b66a 100644 --- a/board/cr50/board.c +++ b/board/cr50/board.c @@ -1571,7 +1571,7 @@ static int get_strap_config(uint8_t *config) if ((i2c_prop && spi_prop) || (!spi_prop && !i2c_prop)) return EC_ERROR_INVAL; use_spi = spi_prop; - CPRINTS("Ambiguous strap config. Use %s based on old " + CPRINTS("WARN Ambiguous strap cfg. Use %s based on old " "brdprop.", use_spi ? "spi" : "i2c"); } @@ -1599,8 +1599,8 @@ static uint32_t get_properties(void) * is no point in checking for a matching config table entry. * For this case use default properties. */ - CPRINTS("Invalid strap pins! Default properties = 0x%x", - BOARD_PROPERTIES_DEFAULT); + CPRINTS("ERROR INVALID STRAP PINS!!! cfg 0x%0x prop 0x%x", + config, BOARD_PROPERTIES_DEFAULT); return BOARD_PROPERTIES_DEFAULT; } @@ -1632,7 +1632,7 @@ static uint32_t get_properties(void) properties = BOARD_PROPERTIES_DEFAULT; } flog_brdprop_event(BRDPROP_NO_ENTRY, config); - CPRINTS("strap_cfg 0x%x has no table entry, prop = 0x%x", + CPRINTS("ERROR NO TABLE ENTRY!!! cfg: 0x%x prop: 0x%x", config, properties); return properties; } |