summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLeo-Tsai <leocx_tsai@compal.corp-partner.google.com>2022-02-15 09:02:48 +0800
committerCommit Bot <commit-bot@chromium.org>2022-02-21 03:53:09 +0000
commit7c923d9ff316bd0e472f4bae1976526428e5e94b (patch)
tree7082324b2548e59c23970daea19966456eb99f54
parentff0106d30a5511531d08407e507b7f1a10518947 (diff)
downloadchrome-ec-7c923d9ff316bd0e472f4bae1976526428e5e94b.tar.gz
Banshee: modify BB-retimer configure
configure BB-retimer I2c address to sync with intel BBR FW BUG=b:219394601 BRANCH=none TEST=build make -j BOARD=Banshee pass Signed-off-by: Leo-Tsai <leocx_tsai@compal.corp-partner.google.com> Change-Id: Ia8637501a9c2fee0046c051a1bfef3eb1f1657cd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3459600 Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Boris Mittelberg <bmbm@google.com>
-rw-r--r--board/banshee/board.h9
-rw-r--r--board/banshee/usbc_config.c8
2 files changed, 8 insertions, 9 deletions
diff --git a/board/banshee/board.h b/board/banshee/board.h
index 700eaf4811..82c0bc6977 100644
--- a/board/banshee/board.h
+++ b/board/banshee/board.h
@@ -168,11 +168,10 @@
#define I2C_ADDR_MP2964_FLAGS 0x20
-/*
- * see b/174768555#comment22
- */
-#define USBC_PORT_C0_C2_BB_RETIMER_I2C_ADDR 0x56
-#define USBC_PORT_C1_C3_BB_RETIMER_I2C_ADDR 0x57
+#define USBC_PORT_C0_BB_RETIMER_I2C_ADDR 0x56
+#define USBC_PORT_C1_BB_RETIMER_I2C_ADDR 0x57
+#define USBC_PORT_C2_BB_RETIMER_I2C_ADDR 0x58
+#define USBC_PORT_C3_BB_RETIMER_I2C_ADDR 0x59
/* Enabling Thunderbolt-compatible mode */
#define CONFIG_USB_PD_TBT_COMPAT_MODE
diff --git a/board/banshee/usbc_config.c b/board/banshee/usbc_config.c
index 8e1e575ed9..77226b367a 100644
--- a/board/banshee/usbc_config.c
+++ b/board/banshee/usbc_config.c
@@ -136,7 +136,7 @@ const struct usb_mux usb_muxes[] = {
.driver = &bb_usb_retimer,
.hpd_update = bb_retimer_hpd_update,
.i2c_port = I2C_PORT_USB_C0_C1_MUX,
- .i2c_addr_flags = USBC_PORT_C0_C2_BB_RETIMER_I2C_ADDR,
+ .i2c_addr_flags = USBC_PORT_C0_BB_RETIMER_I2C_ADDR,
.next_mux = &usbc0_tcss_usb_mux,
},
[USBC_PORT_C1] = {
@@ -144,7 +144,7 @@ const struct usb_mux usb_muxes[] = {
.driver = &bb_usb_retimer,
.hpd_update = bb_retimer_hpd_update,
.i2c_port = I2C_PORT_USB_C0_C1_MUX,
- .i2c_addr_flags = USBC_PORT_C1_C3_BB_RETIMER_I2C_ADDR,
+ .i2c_addr_flags = USBC_PORT_C1_BB_RETIMER_I2C_ADDR,
.next_mux = &usbc1_tcss_usb_mux,
},
[USBC_PORT_C2] = {
@@ -152,7 +152,7 @@ const struct usb_mux usb_muxes[] = {
.driver = &bb_usb_retimer,
.hpd_update = bb_retimer_hpd_update,
.i2c_port = I2C_PORT_USB_C2_C3_MUX,
- .i2c_addr_flags = USBC_PORT_C0_C2_BB_RETIMER_I2C_ADDR,
+ .i2c_addr_flags = USBC_PORT_C2_BB_RETIMER_I2C_ADDR,
.next_mux = &usbc2_tcss_usb_mux,
},
[USBC_PORT_C3] = {
@@ -160,7 +160,7 @@ const struct usb_mux usb_muxes[] = {
.driver = &bb_usb_retimer,
.hpd_update = bb_retimer_hpd_update,
.i2c_port = I2C_PORT_USB_C2_C3_MUX,
- .i2c_addr_flags = USBC_PORT_C1_C3_BB_RETIMER_I2C_ADDR,
+ .i2c_addr_flags = USBC_PORT_C3_BB_RETIMER_I2C_ADDR,
.next_mux = &usbc3_tcss_usb_mux,
},
};