diff options
| author | Abe Levkoy <alevkoy@chromium.org> | 2022-02-02 14:11:37 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2022-02-15 23:04:27 +0000 |
| commit | 316bdef1388ee3ff9b8fe4a5c37e4b8347230798 (patch) | |
| tree | 40455e69687e9e9a6e123c51028f46f4e730f771 | |
| parent | 3abadc3e227dea8c1c53d867db911690b2dd251b (diff) | |
| download | chrome-ec-316bdef1388ee3ff9b8fe4a5c37e4b8347230798.tar.gz | |
TCPMv2: Data Reset to exit modes
Try to Data Reset when exiting alternate modes or USB4. For alternate
modes still try Exit Mode if Data Reset isn't supported.
BUG=b:209625351
TEST=Attach USB4 hub; ectool typeccontrol 1 0; observe PD traffic
BRANCH=none
Cq-Depend: chromium:3465516
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: Icfc8af8b6d7d47313ce1d1659db47fe3ad2d330c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3436451
Reviewed-by: Diana Z <dzigterman@chromium.org>
| -rw-r--r-- | common/usbc/usb_pd_dpm.c | 27 |
1 files changed, 23 insertions, 4 deletions
diff --git a/common/usbc/usb_pd_dpm.c b/common/usbc/usb_pd_dpm.c index 5deea53d5d..bd5706ba98 100644 --- a/common/usbc/usb_pd_dpm.c +++ b/common/usbc/usb_pd_dpm.c @@ -164,6 +164,7 @@ static void dpm_set_mode_entry_done(int port) void dpm_set_mode_exit_request(int port) { DPM_SET_FLAG(port, DPM_FLAG_EXIT_REQUEST); + DPM_CLR_FLAG(port, DPM_FLAG_DATA_RESET_DONE); } void dpm_data_reset_complete(int port) @@ -414,8 +415,27 @@ static void dpm_attempt_mode_exit(int port) enum dpm_msg_setup_status status = MSG_SETUP_ERROR; enum tcpci_msg_type tx_type = TCPCI_MSG_SOP; - if (IS_ENABLED(CONFIG_USB_PD_USB4) && - enter_usb_entry_is_done(port)) { + /* First, try Data Reset. If Data Reset completes, all the alt mode + * state checked below will reset to its inactive state. If Data Reset + * is not supported, exit active modes individually. + */ + if (IS_ENABLED(CONFIG_USB_PD_DATA_RESET_MSG)) { + if (!DPM_CHK_FLAG(port, DPM_FLAG_DATA_RESET_REQUESTED) + && !DPM_CHK_FLAG(port, + DPM_FLAG_DATA_RESET_DONE)) { + pd_dpm_request(port, DPM_REQUEST_DATA_RESET); + DPM_SET_FLAG(port, DPM_FLAG_DATA_RESET_REQUESTED); + return; + } else if (!DPM_CHK_FLAG(port, DPM_FLAG_DATA_RESET_DONE)) { + return; + } + /* TODO(b/209625351): Check for Not Supported case. */ + } + + /* TODO(b/209625351): Data Reset is the only real way to exit from USB4 + * mode. If that failed, the TCPM shouldn't try anything else. + */ + if (IS_ENABLED(CONFIG_USB_PD_USB4) && enter_usb_entry_is_done(port)) { CPRINTS("C%d: USB4 teardown", port); usb4_exit_mode_request(port); } @@ -428,8 +448,7 @@ static void dpm_attempt_mode_exit(int port) if (IS_ENABLED(CONFIG_USBC_SS_MUX) && !usb_mux_set_completed(port)) return; - if (IS_ENABLED(CONFIG_USB_PD_TBT_COMPAT_MODE) && - tbt_is_active(port)) { + if (IS_ENABLED(CONFIG_USB_PD_TBT_COMPAT_MODE) && tbt_is_active(port)) { /* * When the port is in USB4 mode and receives an exit request, * it leaves USB4 SOP in active state. |