diff options
| author | Wai-Hong Tam <waihong@google.com> | 2022-02-15 12:07:25 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2022-02-16 01:55:58 +0000 |
| commit | 0f02290de91879b7cd9f50abcdf8e6357c21e45b (patch) | |
| tree | c8abd95b45c8fb1a49f26fe9e66bcd986388209b | |
| parent | 757b2b7708d60482922eb9c3cff2abc803967dae (diff) | |
| download | chrome-ec-0f02290de91879b7cd9f50abcdf8e6357c21e45b.tar.gz | |
qcom: Unconditionally disable AP_RST_L interrupt on power off
Move disabling the AP_RST_L interrupt out of the if clause. The if
clause won't be entered if the shutdown is triggered by POWER GOOD
lost.
BRANCH=None
BUG=b:218878427
TEST=Triggered the power off sequence from the AP side. Checked the
AP_RST_L interrupt disabled.
Change-Id: I69c22a44f6fa42ec4397b52a7a2d9d025c2de5b4
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3466416
Reviewed-by: Alexandru Stan <amstan@chromium.org>
| -rw-r--r-- | power/qcom.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/power/qcom.c b/power/qcom.c index faa6b4c703..edb3230490 100644 --- a/power/qcom.c +++ b/power/qcom.c @@ -621,13 +621,14 @@ static void power_off_seq(void) set_pmic_pwron(0); usleep(PMIC_POWER_OFF_DELAY); - /* - * Disable signal interrupts, as they are floating when - * switchcap off. - */ - power_signal_disable_interrupt(GPIO_AP_RST_L); } + /* + * Disable signal interrupts, as they are floating when + * switchcap off. + */ + power_signal_disable_interrupt(GPIO_AP_RST_L); + /* Check the switchcap status */ if (is_system_powered()) { /* Force to switch off all rails */ |