summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMary Ruthven <mruthven@google.com>2018-08-24 14:09:01 -0700
committerCommit Bot <commit-bot@chromium.org>2021-11-18 04:54:27 +0000
commitb5bc684e20fa4470de3a651dde0136bc6204c8e3 (patch)
tree94eca09dd4d9706c4e508fca2f9ca389f569302e
parente6a93af1f7845406f92817a93f02b2803363f480 (diff)
downloadchrome-ec-b5bc684e20fa4470de3a651dde0136bc6204c8e3.tar.gz
ccd_config: add flag restricting ccd open
On prePVT images we want to allow ccd open from the console without dev mode enabled. This change adds a config option limiting ccd open. BUG=b:112861587 TEST=ccd open is still disabled from the console unless the password is set. Change-Id: I2adbf9b0e900a693ab513a6bf6650b320b7320d4 Signed-off-by: Mary Ruthven <mruthven@google.com> Reviewed-on: https://chromium-review.googlesource.com/1188927 Commit-Ready: Mary Ruthven <mruthven@chromium.org> Tested-by: Mary Ruthven <mruthven@chromium.org> Reviewed-by: Randall Spangler <rspangler@chromium.org> (cherry picked from commit 2a4bd4a152d81f5e24cea00b177c0be6d6246d15) Reviewed-on: https://chromium-review.googlesource.com/c/1403842 Tested-by: Vadim Bendebury <vbendeb@chromium.org> Commit-Queue: Vadim Bendebury <vbendeb@chromium.org> Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> (cherry picked from commit d11aa8c6a6e74e6bc579f026ab321d458f88eabe) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273471 Commit-Queue: Mary Ruthven <mruthven@chromium.org> Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
-rw-r--r--common/ccd_config.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/common/ccd_config.c b/common/ccd_config.c
index d87842a055..0189bef185 100644
--- a/common/ccd_config.c
+++ b/common/ccd_config.c
@@ -959,12 +959,14 @@ static enum vendor_cmd_rc ccd_open(struct vendor_cmd_params *p)
* bypass these checks.
*/
} else {
+#ifndef CONFIG_CCD_OPEN_PREPVT
/*
* - Battery is present
* - Either not in developer mode or the command came from USB
*/
why_denied = "open from AP in devmode or remove batt";
goto denied;
+#endif
}
/* Fail and abort if already checking physical presence */