diff options
| author | Mary Ruthven <mruthven@chromium.org> | 2021-06-17 14:30:14 -0500 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-06-18 20:01:39 +0000 |
| commit | 90120a2e36936e9e857ee84e799657d5e54b7ba0 (patch) | |
| tree | c893523319f6be7054422e6919f31d2184715efe | |
| parent | 91e4f3225286ee77664d800cf04cb28e5e310f29 (diff) | |
| download | chrome-ec-90120a2e36936e9e857ee84e799657d5e54b7ba0.tar.gz | |
ccd_config: remove UpdateNoTPMWipe
UpdateNoTPMWipe did not do anything. Replace it with 'Unused' in the
capabilities list.
We can't completely remove the capability because of how cr50 uses
the cap_info list. Every item from 0 to CCD_CAP_COUNT needs to have a
name and a default value. Renaming it makes it clear the capability
isn't used and keeps the relationship between capabilities and their
value in the capabilities bitmask.
BUG=b:182482706
TEST=none
Change-Id: Ie1e6674f414789ae52508b89e6f95d0a122cbd6f
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2970990
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
| -rw-r--r-- | docs/case_closed_debugging_cr50.md | 2 | ||||
| -rw-r--r-- | include/ccd_config.h | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/docs/case_closed_debugging_cr50.md b/docs/case_closed_debugging_cr50.md index a5cad0ed43..b57e99d541 100644 --- a/docs/case_closed_debugging_cr50.md +++ b/docs/case_closed_debugging_cr50.md @@ -63,7 +63,7 @@ Capability | Default | Function `OpenNoTPMWipe` | `IfOpened` | Allow opening Cr50 without wiping the TPM `OpenNoLongPP` | `IfOpened` | Allow opening Cr50 without physical presence `BatteryBypassPP` | `Always` | Allow opening Cr50 without physical presence and developer mode if the battery is removed -`UpdateNoTPMWipe` | `Always` | Allow updating Cr50 without wiping the TPM +`Unused` | `Always` | Doesn't do anything `I2C` | `IfOpened` | Allow access to the I2C controller (used for measuring power) `FlashRead` | `Always` | Allow dumping a hash of the AP or EC flash `OpenNoDevMode` | `IfOpened` | Allow opening Cr50 without developer mode diff --git a/include/ccd_config.h b/include/ccd_config.h index 60abe472e9..87bebb9db3 100644 --- a/include/ccd_config.h +++ b/include/ccd_config.h @@ -114,8 +114,8 @@ enum ccd_capability { /* Allow removing the battery to bypass physical presence requirement */ CCD_CAP_REMOVE_BATTERY_BYPASSES_PP = 13, - /* Allow GSC firmware update without wiping TPM data */ - CCD_CAP_GSC_FW_UPDATE_WITHOUT_TPM_WIPE = 14, + /* This was UpdateNoTPMWipe which didn't do anything. */ + CCD_CAP_UNUSED = 14, /* Access to I2C via USB */ CCD_CAP_I2C = 15, @@ -188,7 +188,7 @@ struct ccd_capability_info { \ {"OpenNoLongPP", CCD_CAP_STATE_IF_OPENED}, \ {"BatteryBypassPP", CCD_CAP_STATE_ALWAYS}, \ - {"UpdateNoTPMWipe", CCD_CAP_STATE_ALWAYS}, \ + {"Unused", CCD_CAP_STATE_ALWAYS}, \ {"I2C", CCD_CAP_STATE_IF_OPENED}, \ {"FlashRead", CCD_CAP_STATE_ALWAYS}, \ {"OpenNoDevMode", CCD_CAP_STATE_OPEN_REQ}, \ |