diff options
| author | Wai-Hong Tam <waihong@google.com> | 2021-05-17 16:59:40 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-05-18 15:12:21 +0000 |
| commit | 21f48df7afd2087eb5d0807b9cea0bf5b77bdf5a (patch) | |
| tree | 5d5b98eb436771d15a9817c8e1a89dff63185816 | |
| parent | 70bd26d153cc179aa4f0badef36d04d6e53febb2 (diff) | |
| download | chrome-ec-21f48df7afd2087eb5d0807b9cea0bf5b77bdf5a.tar.gz | |
zephyr: lazor: Use correct power signal interrupt handlers
The SC7180 power signals, like AP_RST_L, WARM_RESET, and POWER_GOOD
need special interrupt handlers. Missing them will cause:
* AP warm reset doesn't notify the reset hook;
* AP firmware flashing may fail.
BRANCH=None
BUG=b:183054226
TEST=Toggling the WARM_RESET, like `dut-control warm_reset:off`,
EC UART shows the message:
Long warm reset ended, cold resetting to restore confidence.
TEST=Execute AP warm reset, check it triggers CHIPSET reset hook.
Change-Id: Id6ea38abb1a10017bf603852908ac6d5dd6f78f4
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2901239
Reviewed-by: Alexandru M Stan <amstan@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
| -rw-r--r-- | zephyr/projects/trogdor/lazor/include/gpio_map.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/zephyr/projects/trogdor/lazor/include/gpio_map.h b/zephyr/projects/trogdor/lazor/include/gpio_map.h index 13d07824e1..00ee9c48e1 100644 --- a/zephyr/projects/trogdor/lazor/include/gpio_map.h +++ b/zephyr/projects/trogdor/lazor/include/gpio_map.h @@ -38,14 +38,15 @@ GPIO_INT(GPIO_VOLUME_UP_L, GPIO_INT_EDGE_BOTH, button_interrupt) \ GPIO_INT(GPIO_SWITCHCAP_PG_INT_L, GPIO_INT_EDGE_FALLING, \ ln9310_interrupt) \ - GPIO_INT(GPIO_AP_RST_L, GPIO_INT_EDGE_BOTH, power_signal_interrupt) \ + GPIO_INT(GPIO_AP_RST_L, GPIO_INT_EDGE_BOTH, chipset_ap_rst_interrupt) \ GPIO_INT(GPIO_AP_SUSPEND, GPIO_INT_EDGE_BOTH, power_signal_interrupt) \ GPIO_INT(GPIO_DEPRECATED_AP_RST_REQ, GPIO_INT_EDGE_BOTH, \ power_signal_interrupt) \ - GPIO_INT(GPIO_POWER_GOOD, GPIO_INT_EDGE_BOTH, power_signal_interrupt) \ + GPIO_INT(GPIO_POWER_GOOD, GPIO_INT_EDGE_BOTH, \ + chipset_power_good_interrupt) \ GPIO_INT(GPIO_PS_HOLD, GPIO_INT_EDGE_BOTH, power_signal_interrupt) \ GPIO_INT(GPIO_WARM_RESET_L, GPIO_INT_EDGE_BOTH, \ - power_signal_interrupt) \ + chipset_warm_reset_interrupt) \ GPIO_INT(GPIO_USB_C0_PD_INT_ODL, GPIO_INT_EDGE_FALLING, \ tcpc_alert_event) \ GPIO_INT(GPIO_USB_C1_PD_INT_ODL, GPIO_INT_EDGE_FALLING, \ |