summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaveh Jalali <caveh@chromium.org>2021-03-30 02:34:36 -0700
committerCommit Bot <commit-bot@chromium.org>2021-04-08 16:12:18 +0000
commitf4c859c75a79e54222fd9f05121e2a6f79e74123 (patch)
treeb178a7ae0f3a2b56e4a4b0817e87199b4f81e2d0
parent09105c331418e7c1ba37e69ff0494021291fb900 (diff)
downloadchrome-ec-f4c859c75a79e54222fd9f05121e2a6f79e74123.tar.gz
brya: Assert PROCHOT when VSYS droops too low
This addresses a problem where brya shuts down when running without a battery. The root cause is that VSYS droops too much when SoC power demand spikes. The solution is to raise the VSYS_TH2 threshold in the bq25720 charger chip to provide an early throttle feedback signal to the SoC during high load. The default threshold is 5.9v which is low enough to cause problems. On Brya, we see VSYS drop all the way down to 5.4v at which point the SoC shuts down. The voltage should never be drawn down that low, so tune the charger to assert PROCHOT at 7.0v instead. This throttles the SoC sufficiently during high load to avoid instability. 7.0v was selected after consulting with EE team. BRANCH=none BUG=b:183474163 TEST=booted brya to the OS without a battery Change-Id: Id06e567b9f8a499da7ceb345e673e091c94d90c2 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2798980 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Will Arthur <wda@google.com> Commit-Queue: Keith Short <keithshort@chromium.org>
-rw-r--r--board/brya/board.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/board/brya/board.h b/board/brya/board.h
index 5197026af0..80c3fc04a3 100644
--- a/board/brya/board.h
+++ b/board/brya/board.h
@@ -151,6 +151,7 @@
/* Charger defines */
#define CONFIG_CHARGER_BQ25720
+#define CONFIG_CHARGER_BQ25720_VSYS_TH2_DV 70
#define CONFIG_CHARGE_RAMP_SW
#define CONFIG_CHARGER_SENSE_RESISTOR 10
#define CONFIG_CHARGER_SENSE_RESISTOR_AC 10