diff options
| author | Caveh Jalali <caveh@chromium.org> | 2021-03-02 23:13:43 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-03-04 02:25:29 +0000 |
| commit | e0bfb89ba8ad0c36dfbd23fb1d3ff9e6b2a8de39 (patch) | |
| tree | eb9b814efa7a00f76039522dee6562be160b768a | |
| parent | 60f9fb600f19c157ca118063dcfc067fa6cff529 (diff) | |
| download | chrome-ec-e0bfb89ba8ad0c36dfbd23fb1d3ff9e6b2a8de39.tar.gz | |
bb_retimer: Fix port bounds check
This fixes a bounds check in the 'bb' command argument parsing.
BRANCH=none
BUG=none
TEST=EC no longer resets when triggering the off-by-one error
Change-Id: I4ff459781c047b3899150485b7fd3fe6363bdec3
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2730521
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
| -rw-r--r-- | driver/retimer/bb_retimer.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/driver/retimer/bb_retimer.c b/driver/retimer/bb_retimer.c index a8e93949c1..cbaf58cb61 100644 --- a/driver/retimer/bb_retimer.c +++ b/driver/retimer/bb_retimer.c @@ -527,7 +527,7 @@ static int console_command_bb_retimer(int argc, char **argv) /* Get port number */ port = strtoi(argv[1], &e, 0); - if (*e || port < 0 || port > board_get_usb_pd_port_count()) + if (*e || !board_is_usb_pd_port_present(port)) return EC_ERROR_PARAM1; mux = &usb_muxes[port]; |