summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVadim Bendebury <vbendeb@chromium.org>2020-06-29 12:58:31 -0700
committerCommit Bot <commit-bot@chromium.org>2020-06-29 20:53:32 +0000
commitacbcdd851d89a97fd2c9fd77a06951d010926927 (patch)
tree1a8d5996b660c7c7cd712fe91b7c47f6efbd40c9
parenta12d9f33ec06e33e25337e24979722baf2f3956f (diff)
downloadchrome-ec-acbcdd851d89a97fd2c9fd77a06951d010926927.tar.gz
cr50_vboot_doc: improve picture renedering
This patch addresses gerrit markdown rendering deficiency where the target image is not properly rendered gerrit by the gerrit server. The images were duplicated on Google Drive, such that the smaller in the page version of the image is still loaded from the local tree, but the target image comes from Drive, which allows to see full size images when required. BUG=none TEST=verified proper rendering of the full size images Signed-off-by: Vadim Bendebury <vbendeb@chromium.org> Change-Id: Ief2f18bd9b3805b391b19b8ebb8828d9e5ca05b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2274302 Reviewed-by: Mary Ruthven <mruthven@chromium.org>
-rw-r--r--docs/cr50_vboot_troubleshooting.md37
1 files changed, 22 insertions, 15 deletions
diff --git a/docs/cr50_vboot_troubleshooting.md b/docs/cr50_vboot_troubleshooting.md
index a81eb62afc..eba6974a61 100644
--- a/docs/cr50_vboot_troubleshooting.md
+++ b/docs/cr50_vboot_troubleshooting.md
@@ -202,22 +202,29 @@ Saleae application in the trace analysis mode.
A few detailed snapshots of this trace are shown below (click to expand):
### Full boot sequence
-[![Full boot sequence](./images/typical_boot.png)](./images/typical_boot.png) shows communications between AP
-an H1 during a typical Chrome OS boot: first a flurry of communications
-between Coreboot and the H1, then some time spent verifying and loading
-various firmware stages, then a block of communications between Depthcarge and
-the H1.
+
+[![Full boot sequence](./images/typical_boot.png)][1] shows communications
+between AP an H1 during a typical Chrome OS boot: first a flurry of
+communications between Coreboot and the H1, then some time spent verifying and
+loading various firmware stages, then a block of communications between
+Depthcarge and the H1.
### Typical read sequence
-[![Typical read sequence](./images/typical_read.png)](./images/typical_read.png) shows the 4 byte header
-where the read of four bytes from register address 0xd40f00 is requested. The
-TPM is not ready and sends all zeros on the MISO line for three cycles, then
-sends a byte of 01 and then the AP reads four bytes of the actual register
-value (0xe01a2800). Then, after H1 is ready to accept the next SPI transaction
-it generates a pulse on AP\_INT\_L.
+
+[![Typical read sequence](./images/typical_read.png)][2] shows the 4 byte
+header where the read of four bytes from register address 0xd40f00 is
+requested. The TPM is not ready and sends all zeros on the MISO line for three
+cycles, then sends a byte of 01 and then the AP reads four bytes of the actual
+register value (0xe01a2800). Then, after H1 is ready to accept the next SPI
+transaction it generates a pulse on AP\_INT\_L.
### Read with wake pulse sequence
-[![Read with wake pulse](./images/read_with_wake_pulse.png)](./images/read_with_wake_pulse.png) is an example of a
-case where the AP toggles the CS line first, without sending any data, and
-then in 100 us starts the actual SPI transaction completed with the AP\_INT\_L
-pulse.
+
+[![Read with wake pulse](./images/read_with_wake_pulse.png)][3] is an example
+of a case where the AP toggles the CS line first, without sending any data,
+and then in 100 us starts the actual SPI transaction completed with the
+AP\_INT\_L pulse.
+
+[1]:https://drive.google.com/file/d/16Z_Nw1e6z5akUnyLZyI8ivfT5frxKPQh/view
+[2]:https://drive.google.com/file/d/1weBd6kBiXoQ0I3TGmbpiHZm0dimByYnI/view
+[3]:https://drive.google.com/file/d/13ZSP3up4leG0Etqo4A_gkFK1MeptGDCw/view