diff options
| author | Scott Collyer <scollyer@google.com> | 2019-09-03 16:43:42 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-09-12 21:44:40 +0000 |
| commit | 8f47673f345df83c67e930113043c45d1c698b44 (patch) | |
| tree | b87b41fb83c2a1eb7355b85f2d89641bfc91e1a6 | |
| parent | eac716b4f6a89873ce7585b63167a4ee4b2dfa3d (diff) | |
| download | chrome-ec-8f47673f345df83c67e930113043c45d1c698b44.tar.gz | |
cometlake: Remove TODO comment from chipset_force_shutdown
There was a todo to replace a while loop with a call to
power_wait_signals_timeout. However, using that function is not
feasible in this case as it's only intended to check for power signals
that are high. Removing the TODO comment since it's not applicable.
BUG=b:122264541
BRANCH=None
TEST=make BOARD=hatch
Change-Id: I0dca060f8a8e00bc99a433d78dd55d262a867cb1
Signed-off-by: Scott Collyer <scollyer@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1783521
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Scott Collyer <scollyer@chromium.org>
| -rw-r--r-- | power/cometlake.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/power/cometlake.c b/power/cometlake.c index 32363a5f34..66f3796e44 100644 --- a/power/cometlake.c +++ b/power/cometlake.c @@ -78,10 +78,6 @@ void chipset_force_shutdown(enum chipset_shutdown_reason reason) /* Need to wait a min of 10 msec before check for power good */ msleep(10); - /* - * TODO(b/122264541): Replace this wait with - * power_wait_signals_timeout() - */ /* Now wait for PP5000_A and RSMRST_L to go low */ while ((gpio_get_level(GPIO_PP5000_A_PG_OD) || power_has_signals(IN_PGOOD_ALL_CORE)) && (timeout_ms > 0)) { |