summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Georgi <pgeorgi@google.com>2019-09-12 14:48:50 +0200
committerCommit Bot <commit-bot@chromium.org>2019-09-12 23:36:52 +0000
commit77424e473fd1f47caf6b9e5621defc4bab51468a (patch)
treecf60c51700cd34d635a80e86f30dac2eb7692a82
parent89267691e5cce30ef80fd1d1b1c360d912db30cf (diff)
downloadchrome-ec-77424e473fd1f47caf6b9e5621defc4bab51468a.tar.gz
chip/nrf51/gpio.c: Actually check the flag (instead of == 0)
Found by Coverity Scan #146623 BUG=none BRANCH=none TEST=none Change-Id: I04ca143f794596c7be00f69ee297b33759125ae2 Signed-off-by: Patrick Georgi <pgeorgi@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1801204 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Patrick Georgi <pgeorgi@chromium.org> Commit-Queue: Patrick Georgi <pgeorgi@chromium.org>
-rw-r--r--chip/nrf51/gpio.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/chip/nrf51/gpio.c b/chip/nrf51/gpio.c
index 9d6067bb70..48c9f39895 100644
--- a/chip/nrf51/gpio.c
+++ b/chip/nrf51/gpio.c
@@ -257,7 +257,7 @@ int gpio_disable_interrupt(enum gpio_signal signal)
return EC_ERROR_INVAL;
/* If it's not shared, use INT0-INT3, otherwise use PORT. */
- if (!(g->flags && GPIO_INT_SHARED)) {
+ if (!(g->flags & GPIO_INT_SHARED)) {
for (i = 0; i < NRF51_GPIOTE_IN_COUNT; i++) {
/* Remove matching handler. */
if (gpio_ints[i] == g) {