summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Georgi <pgeorgi@google.com>2019-09-09 22:42:19 +0200
committerCommit Bot <commit-bot@chromium.org>2019-09-12 11:42:05 +0000
commit69d0f6e2c66c164bd4de5d279ace4b303db04f1b (patch)
tree6d7662bafbf486863a58c8bf4545f07c3703c8f4
parent87502c08eb8b5855465257c314c5273fc7af7b26 (diff)
downloadchrome-ec-69d0f6e2c66c164bd4de5d279ace4b303db04f1b.tar.gz
common/flash.c: Support finding the flash_bank_index for offset 0
According to the algorithm that's always the first entry, but it always returned -1 so far. Found by Coverity Scan #174434 BUG=none BRANCH=none TEST=none Change-Id: Idd3f2794b559bea47f8425791351a8d0bc1424d6 Signed-off-by: Patrick Georgi <pgeorgi@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1793583 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Patrick Georgi <pgeorgi@chromium.org> Commit-Queue: Patrick Georgi <pgeorgi@chromium.org>
-rw-r--r--common/flash.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/common/flash.c b/common/flash.c
index 1127c2cfcb..632153a99b 100644
--- a/common/flash.c
+++ b/common/flash.c
@@ -155,6 +155,9 @@ int flash_bank_index(int offset)
{
int bank_offset = 0, i;
+ if (offset == 0)
+ return bank_offset;
+
for (i = 0; i < ARRAY_SIZE(flash_bank_array); i++) {
int all_sector_size = flash_bank_array[i].count <<
flash_bank_array[i].size_exp;