summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaveh Jalali <caveh@chromium.org>2019-09-11 22:58:04 -0700
committerCommit Bot <commit-bot@chromium.org>2019-09-13 01:42:05 +0000
commit38bb196419ace3bc47a6380fcec53d77e271d16d (patch)
treed0883ece3b2c3c32245ec28f7b4d43efdf626915
parent9a4cf337a21a936fbe2a26c58e17b5ba72cc633d (diff)
downloadchrome-ec-38bb196419ace3bc47a6380fcec53d77e271d16d.tar.gz
Makefile.rules: do not ignore compilation errors
for some reason, Makefile.rules is set up to ignore compilation errors on npcx_monitor. this seems very wrong. BRANCH=none BUG=none TEST=make proj-atlas now fails - an existing compilation now fails the build Cq-Depend: chromium:1799293 Change-Id: I8ba9b8bc05d9b11df6a4f79bbcc2bbf7e48b224d Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1799294 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Caveh Jalali <caveh@google.com>
-rw-r--r--Makefile.rules16
1 files changed, 8 insertions, 8 deletions
diff --git a/Makefile.rules b/Makefile.rules
index 6777fa24b1..2b081b1f76 100644
--- a/Makefile.rules
+++ b/Makefile.rules
@@ -590,27 +590,27 @@ $(out)/tags: $(out)/cscope.files
# TODO: optional make rules for PROJECT_EXTRA
$(npcx-monitor-fw-bin):
$(if $(V),,@echo ' EXTBIN ' $(subst $(out)/,,$@) ; )
- -@ mkdir -p $(@D)
- -@ $(CC) $(CFLAGS) -MMD -MF $(out)/$(npcx-lfw).d -c $(npcx-monitor-fw).c \
+ $(Q)mkdir -p $(@D)
+ $(Q)$(CC) $(CFLAGS) -MMD -MF $(out)/$(npcx-lfw).d -c $(npcx-monitor-fw).c \
-o $(out)/$(npcx-monitor-fw).o
- -@ $(CC) $(out)/$(npcx-monitor-fw).o $(LDFLAGS) \
+ $(Q)$(CC) $(out)/$(npcx-monitor-fw).o $(LDFLAGS) \
-o $(out)/$(npcx-monitor-fw).elf -Wl,-T,$(npcx-monitor-fw).ld \
-Wl,-Map,$(out)/$(npcx-monitor-fw).map
- -@ $(OBJCOPY) -O binary $(out)/$(npcx-monitor-fw).elf $@
+ $(Q)$(OBJCOPY) -O binary $(out)/$(npcx-monitor-fw).elf $@
$(out)/$(npcx-monitor-hdr)_ro.o:$(npcx-monitor-hdr).c
- -@ $(CC) $(CFLAGS) -DSECTION_IS_RO=$(EMPTY) -MMD -c $(npcx-monitor-hdr).c -o $@
+ $(Q)$(CC) $(CFLAGS) -DSECTION_IS_RO=$(EMPTY) -MMD -c $(npcx-monitor-hdr).c -o $@
$(npcx-monitor-hdr-ro-bin):$(out)/$(npcx-monitor-hdr)_ro.o
$(if $(V),,@echo ' EXTBIN ' $(subst $(out)/,,$@) ; )
- -@ $(OBJCOPY) -O binary $< $@
+ $(Q)$(OBJCOPY) -O binary $< $@
$(out)/$(npcx-monitor-hdr)_rw.o:$(npcx-monitor-hdr).c
- -@ $(CC) $(CFLAGS) -MMD -c $(npcx-monitor-hdr).c -o $@
+ $(Q)$(CC) $(CFLAGS) -MMD -c $(npcx-monitor-hdr).c -o $@
$(npcx-monitor-hdr-rw-bin):$(out)/$(npcx-monitor-hdr)_rw.o
$(if $(V),,@echo ' EXTBIN ' $(subst $(out)/,,$@) ; )
- -@ $(OBJCOPY) -O binary $< $@
+ $(Q)$(OBJCOPY) -O binary $< $@
.PHONY: xrefs
xrefs: $(call targ_if_prog,etags,$(out)/TAGS) \