diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2019-07-02 11:23:07 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-07-17 23:58:24 +0000 |
| commit | 048e8abbb05ec7758045cb43dbc71fa1ecc93fbe (patch) | |
| tree | 0e901bc9352f3f31929daefabaabf8702c691b3c | |
| parent | 5122fe8bfba938c9c8e32930bc560b499e331420 (diff) | |
| download | chrome-ec-048e8abbb05ec7758045cb43dbc71fa1ecc93fbe.tar.gz | |
nocturne: Don't wake on any MKBP in suspend.
By fixing the bug(b/136282898) to allow MKBP events to wake the system
in suspend, all MKBP events would wake the system which goes against our
chrome OS wake sources spec. By defining CONFIG_MKBP_EVENT_WAKEUP_MASK,
nocturne will not wake on any MKBP event.
BUG=chromium:786721
BRANCH=firmware-nocturne-10984.B
TEST=Build and flash nocturne, suspend DUT, plug in powered charge-thru
hub w/ an external display connected, verify that DUT does not wakes up
and display is not shown.
Change-Id: I0810d0ea625689ee39f0e52b62a8ee7c00c49aad
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1685788
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Alexandru M Stan <amstan@chromium.org>
| -rw-r--r-- | board/nocturne/board.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/board/nocturne/board.h b/board/nocturne/board.h index 51d7ae6906..c1eec1d179 100644 --- a/board/nocturne/board.h +++ b/board/nocturne/board.h @@ -85,8 +85,9 @@ /* MKBP */ #define CONFIG_MKBP_EVENT +#define CONFIG_MKBP_EVENT_WAKEUP_MASK 0 #define CONFIG_KEYBOARD_PROTOCOL_MKBP -#define CONFIG_MKBP_USE_GPIO +#define CONFIG_MKBP_USE_GPIO_AND_HOST_EVENT /* Sensors */ #define CONFIG_ALS |