summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNicolas Boichat <drinkcat@chromium.org>2019-07-28 23:14:46 +0800
committerCommit Bot <commit-bot@chromium.org>2019-08-01 22:34:04 +0000
commit4d89bbd7ba075eeccf67377171c7663dc9bb2f1e (patch)
treef80a39e24653287cc81e6db6bd9c68561a839b67
parent95ff1a1b6af7183160b8de1f480d32430afc1b97 (diff)
downloadchrome-ec-4d89bbd7ba075eeccf67377171c7663dc9bb2f1e.tar.gz
mkbp_event: Only declare EC_CMD_MKBP_WAKE_MASK host command if needed
No need to use up flash space if the command is not supported anyway. BRANCH=none BUG=chromium:988303 TEST=make buildall -j TEST=make BOARD=jerry -j32, see that there is still 156 bytes free Save 64-128 bytes on most boards. Change-Id: Ib0494969840dfc4c11d236a2932f5de688ad6d14 Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1723611 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> (cherry picked from commit 7c34f1301021a998d41b7970201c79cfe846d199) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1730968
-rw-r--r--common/mkbp_event.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/common/mkbp_event.c b/common/mkbp_event.c
index 90c1e90b76..3afab8976c 100644
--- a/common/mkbp_event.c
+++ b/common/mkbp_event.c
@@ -394,6 +394,8 @@ DECLARE_HOST_COMMAND(EC_CMD_HOST_EVENT_GET_WAKE_MASK,
#endif /* CONFIG_MKBP_USE_HOST_EVENT */
#endif /* CONFIG_MKBP_HOST_EVENT_WAKEUP_MASK */
+#if defined(CONFIG_MKBP_EVENT_WAKEUP_MASK) || \
+ defined(CONFIG_MKBP_HOST_EVENT_WAKEUP_MASK)
static int hc_mkbp_wake_mask(struct host_cmd_handler_args *args)
{
struct ec_response_mkbp_event_wake_mask *r = args->response;
@@ -465,8 +467,6 @@ DECLARE_HOST_COMMAND(EC_CMD_MKBP_WAKE_MASK,
hc_mkbp_wake_mask,
EC_VER_MASK(0));
-#if defined(CONFIG_MKBP_EVENT_WAKEUP_MASK) || \
- defined(CONFIG_MKBP_HOST_EVENT_WAKEUP_MASK)
static int command_mkbp_wake_mask(int argc, char **argv)
{
if (argc == 3) {