diff options
| author | Daisuke Nojiri <dnojiri@chromium.org> | 2018-11-21 09:59:49 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-11-27 00:34:08 -0800 |
| commit | e30e82ab31ce6f9bc3dfbde5b70d08b6fb54b409 (patch) | |
| tree | 030442e09c23a66b5e1236d5175d40da8378575b | |
| parent | 06d75d91555d5fc59862684e550c5fc915167660 (diff) | |
| download | chrome-ec-e30e82ab31ce6f9bc3dfbde5b70d08b6fb54b409.tar.gz | |
CEC: Set pull-up high
GPIO pins don't get set high or low after sysjump. This cause
CEC not to work if RO image doesn't set CEC_GPIO_PULL_UP.
This patch sets CEC_GPIO_PULL_UP to high in cec_init.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
BUG=b:119901859
BRANCH=none
TEST=Verify CEC_PULL_UP=1 on Teemo in normal mode and recovery mode.
Change-Id: I0c88a789a8731054c2e4b0bb1066529933473b70
Reviewed-on: https://chromium-review.googlesource.com/c/1346990
Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Stefan Adolfsson <sadolfsson@chromium.org>
(cherry picked from commit 258e4a3d2c89cbf1f81e384bc179cb748611f24e)
Reviewed-on: https://chromium-review.googlesource.com/1347013
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
| -rw-r--r-- | chip/npcx/cec.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/chip/npcx/cec.c b/chip/npcx/cec.c index 60864bef56..ea016805c0 100644 --- a/chip/npcx/cec.c +++ b/chip/npcx/cec.c @@ -1003,6 +1003,9 @@ static void cec_init(void) /* Enable capture TCNT1 into TCRA and preset TCNT1. */ SET_BIT(NPCX_TMCTRL(mdl), NPCX_TMCTRL_TAEN); + /* If RO doesn't set it, RW needs to set it explicitly. */ + gpio_set_level(CEC_GPIO_PULL_UP, 1); + CPRINTS("CEC initialized"); } DECLARE_HOOK(HOOK_INIT, cec_init, HOOK_PRIO_LAST); |