diff options
| author | Enrico Granata <egranata@chromium.org> | 2018-11-28 14:58:14 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-11-29 12:11:06 -0800 |
| commit | 4c3621ace087613604f6d5fb094da62434333893 (patch) | |
| tree | 051bf36020bd942fa1792df759644dece298a998 | |
| parent | e9022668702c87c7403a0548a9236cc68b763df7 (diff) | |
| download | chrome-ec-4c3621ace087613604f6d5fb094da62434333893.tar.gz | |
nocturne: Change FIFO settings
Overly large sensor batches lead to timestamp synchronization
issues on Nocturne, causing - among others - CTS to sometimes
fail the sensor batching tests.
Reduce the size of the FIFO and restore the threshold to being
a third of the size. This value was changed in CL:1134494 in an
attempt to solve a problem which turned out to be unrelated.
BUG=b:117169255, b:73551961, b:120100420, b:120098451
BRANCH=nocturne
TEST=run CTS sensor test cases, observe them pass
Change-Id: Ia27bfe0a4756c22d4e48ba525d585ff11ab1cb63
Signed-off-by: Enrico Granata <egranata@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1354484
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
| -rw-r--r-- | board/nocturne/board.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/board/nocturne/board.h b/board/nocturne/board.h index 63c409678b..fcd9adb5fd 100644 --- a/board/nocturne/board.h +++ b/board/nocturne/board.h @@ -92,9 +92,9 @@ #define ALS_COUNT 1 #define CONFIG_ALS_OPT3001 #define OPT3001_I2C_ADDR OPT3001_I2C_ADDR1 -#define CONFIG_ACCEL_FIFO 1024 /* Must be a power of 2 */ +#define CONFIG_ACCEL_FIFO 512 /* Must be a power of 2 */ /* Depends on how fast the AP boots and typical ODRs */ -#define CONFIG_ACCEL_FIFO_THRES (CONFIG_ACCEL_FIFO / 100) +#define CONFIG_ACCEL_FIFO_THRES (CONFIG_ACCEL_FIFO / 3) #define CONFIG_ACCEL_INTERRUPTS #define CONFIG_ACCELGYRO_BMI160 #define CONFIG_ACCELGYRO_BMI160_INT_EVENT TASK_EVENT_CUSTOM(4) |