diff options
| author | Patrick Georgi <pgeorgi@google.com> | 2018-08-06 14:24:54 +0200 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-08-15 16:37:12 -0700 |
| commit | 2943eed83037dce551813cd50a05cdfb6380106e (patch) | |
| tree | e8670a69c1331626b676f073f5f082fb78bcad5a | |
| parent | fc0f071e171c3eb8904d0eaf2b609a328ce9c7ff (diff) | |
| download | chrome-ec-2943eed83037dce551813cd50a05cdfb6380106e.tar.gz | |
util/ectool_keyscan: don't pretend to report passing tests
The code looked like it reports both failing and passing tests, except
that the line in question is only executed on failure.
Change-Id: Ie733f517c00a18297c36fae0e18bb9adabba438a
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Found-by: Coverity Scan #58156
Reviewed-on: https://chromium-review.googlesource.com/1163609
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@google.com>
| -rw-r--r-- | util/ectool_keyscan.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/util/ectool_keyscan.c b/util/ectool_keyscan.c index 863906eda0..ce35757a19 100644 --- a/util/ectool_keyscan.c +++ b/util/ectool_keyscan.c @@ -635,8 +635,7 @@ static int keyscan_run_tests(struct keyscan_info *keyscan) err = run_test(keyscan, test); any_err |= err; if (err) { - printf("%d: %s: ", testnum, test->name); - printf(" : %s\n", err ? "FAIL" : "pass"); + printf("%d: %s: : FAIL\n", testnum, test->name); } } |