diff options
| author | Diana Z <dzigterman@chromium.org> | 2018-07-02 13:13:50 -0600 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-07-03 18:18:25 -0700 |
| commit | 36a62bd63bb74183c74bf4987ab6ed2af9119fa9 (patch) | |
| tree | 621b6e7e64bebafc1eec7a7b3fadbe51cccf6d0e | |
| parent | 9b3ab01f0f09cf010bad4838735606f378a98eb4 (diff) | |
| download | chrome-ec-36a62bd63bb74183c74bf4987ab6ed2af9119fa9.tar.gz | |
bip: comment fix to clarify GPIO pins
The bip schematics name the LEDs with "_L", which would seem to imply
they are active low but they are actually active high.
BRANCH=none
BUG=none
TEST=make buildall
Change-Id: I03fe9cbf093753a53559d768cede62339da111f2
Signed-off-by: Diana Z <dzigterman@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1123112
Reviewed-by: Jett Rink <jettrink@chromium.org>
| -rw-r--r-- | board/bip/gpio.inc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/board/bip/gpio.inc b/board/bip/gpio.inc index af2cbf9eb8..9902347cd3 100644 --- a/board/bip/gpio.inc +++ b/board/bip/gpio.inc @@ -102,8 +102,8 @@ GPIO(USB_C1_PD_RST_ODL, PIN(L, 7), GPIO_ODR_HIGH) /* C1 PD Reset */ GPIO(USB2_OTG_ID, PIN(I, 2), GPIO_OUT_LOW) /* OTG ID */ /* LED */ -GPIO(BAT_LED_ORANGE, PIN(A, 6), GPIO_OUT_LOW) /* LED_1_L */ -GPIO(BAT_LED_BLUE, PIN(A, 3), GPIO_OUT_LOW) /* LED_2_L */ +GPIO(BAT_LED_ORANGE, PIN(A, 6), GPIO_OUT_LOW) /* LED_1_L NOTE: actually active high, but labeled _L in the schematics */ +GPIO(BAT_LED_BLUE, PIN(A, 3), GPIO_OUT_LOW) /* LED_2_L NOTE: actually active high, but labeled _L in the schematics */ /* Not implemented in hardware yet */ UNIMPLEMENTED(KB_BL_PWR_EN) |