diff options
| author | Scott Collyer <scollyer@google.com> | 2018-04-10 11:31:45 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-04-11 14:55:37 -0700 |
| commit | be2c5fa602d16f0422c234bf9471120c9bd588bb (patch) | |
| tree | 793a1b48051190080c7db4c0300016fa2edd0464 | |
| parent | 80f0f5c7cf42d32ce27690cb303d6ea26b2e01b9 (diff) | |
| download | chrome-ec-be2c5fa602d16f0422c234bf9471120c9bd588bb.tar.gz | |
tcpci: Change role control setting for auto-toggle enable
In tcpci_tcpc_drp_toggle the role control is being set to
TYPEC_CC_OPEN. This works for the parade tcpci compliant tcpc, but
does not work the anx7447. The tcpci spec has this description for the
role control requirement (4.4.5.2):
If DRP=1b, the only allowed values for CC1/CC2 are Rp/Rp or Rd/Rd.
COMMAND.Look4Connection shall do nothing if CC1/CC2 are not Rp/Rp or
Rd/Rd.
This CL changes the role control setting associated with starting
auto-toggle to be TYPEC_CC_RD.
BUG=b:77544959
BRANCH=NONE
TEST=Verfied that anx7447 does auto toggle between Rd and
Rp. Previously, the TCPC_REG_COMMAND_LOOK4CONNECTION command was being
ignored.
Change-Id: Iea7ce963ebf57c0f3d43005385484913d97774fd
Signed-off-by: Scott Collyer <scollyer@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1005795
Commit-Ready: Scott Collyer <scollyer@chromium.org>
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: S Wang <swang@analogix.corp-partner.google.com>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
| -rw-r--r-- | driver/tcpm/tcpci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/driver/tcpm/tcpci.c b/driver/tcpm/tcpci.c index fd5488ca56..96d6e5ba68 100644 --- a/driver/tcpm/tcpci.c +++ b/driver/tcpm/tcpci.c @@ -150,7 +150,7 @@ int tcpci_tcpc_drp_toggle(int port, int enable) return EC_SUCCESS; } /* Set auto drp toggle */ - rv = set_role_ctrl(port, 1, TYPEC_RP_USB, TYPEC_CC_OPEN); + rv = set_role_ctrl(port, 1, TYPEC_RP_USB, TYPEC_CC_RD); /* Set Look4Connection command */ rv |= tcpc_write(port, TCPC_REG_COMMAND, |