diff options
| author | Jeremy Bettis <jbettis@google.com> | 2021-02-23 15:33:11 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-02-24 22:48:12 +0000 |
| commit | 7ac66e54e8e73018189b0b3dc4e1bae9bfa5bec3 (patch) | |
| tree | a467c19a84e6c7190abf3e1e3ce8708a08fd0d24 | |
| parent | 06e96e94080d3047dcf0737db8350174dc5f5f58 (diff) | |
| download | chrome-ec-7ac66e54e8e73018189b0b3dc4e1bae9bfa5bec3.tar.gz | |
EC: After SRC_HARD_RESET_RECOVER set CHECK_XX_ROLE
Just before moving from state PD_STATE_SRC_DISCONNECTED_DEBOUNCE to
PD_STATE_SRC_STARTUP we set the PD_FLAGS_CHECK_PR_ROLE and
PD_FLAGS_CHECK_DR_ROLE. However when we move from
PD_STATE_SRC_HARD_RESET_RECOVER to PD_STATE_SRC_STARTUP we do not set
those flags. This cl corrects that and sets the flags in both cases.
This will allow the servo to get back into the correct dr_role after a
hard reset.
BUG=b:179532434, b:178417455, b:180051107
TEST=Flashed servo, cc srcdts, pd 1 hard
BRANCH=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I42d5807ab87d3bc001f80ca709a2e72d9e89fe63
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2716862
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
| -rw-r--r-- | common/usb_pd_protocol.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/common/usb_pd_protocol.c b/common/usb_pd_protocol.c index 29b07a0767..b7d0abb2b8 100644 --- a/common/usb_pd_protocol.c +++ b/common/usb_pd_protocol.c @@ -3481,6 +3481,8 @@ void pd_task(void *u) tcpm_set_rx_enable(port, 1); #endif /* CONFIG_USB_PD_TCPM_TCPCI || CONFIG_USB_PD_TCPM_STUB */ + pd[port].flags |= PD_FLAGS_CHECK_PR_ROLE | + PD_FLAGS_CHECK_DR_ROLE; set_state(port, PD_STATE_SRC_STARTUP); break; case PD_STATE_SRC_STARTUP: |