diff options
| author | Jett Rink <jettrink@chromium.org> | 2020-03-31 13:43:03 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-04-01 18:36:52 +0000 |
| commit | dec09934db166678c573c25b405cbfcaea426445 (patch) | |
| tree | 58a6a61786a8bfd776f1e1c48c1833e5352db629 | |
| parent | b5bfa22ec42b7936d02821b0e50c1cf91fb7f279 (diff) | |
| download | chrome-ec-dec09934db166678c573c25b405cbfcaea426445.tar.gz | |
test: add better test prints
Update test runner and mux mock to print information
with tags
Also print out when a test passes for easier debugging
BRANCH=none]
BUG=none
TEST=used in child CL
Change-Id: I29a1193831239c160cf75be20380e677936ba9d8
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2131048
Reviewed-by: Diana Z <dzigterman@chromium.org>
| -rw-r--r-- | common/mock/usb_mux_mock.c | 2 | ||||
| -rw-r--r-- | include/test_util.h | 18 |
2 files changed, 11 insertions, 9 deletions
diff --git a/common/mock/usb_mux_mock.c b/common/mock/usb_mux_mock.c index f367bfeb95..cbd0132836 100644 --- a/common/mock/usb_mux_mock.c +++ b/common/mock/usb_mux_mock.c @@ -27,7 +27,7 @@ static int mock_set(const struct usb_mux *me, mux_state_t mux_state) { mock_usb_mux.state = mux_state; ++mock_usb_mux.num_set_calls; - ccprints("Called into mux with %d", mux_state); + ccprints("[MUX] Set to 0x%02x", mux_state); return EC_SUCCESS; } diff --git a/include/test_util.h b/include/test_util.h index e10dcbe259..53e750f472 100644 --- a/include/test_util.h +++ b/include/test_util.h @@ -17,7 +17,7 @@ #define RUN_TEST(n) \ do { \ - ccprintf("Running %s...", #n); \ + ccprintf("Running %s...\n", #n); \ cflush(); \ before_test(); \ if (n() == EC_SUCCESS) { \ @@ -44,15 +44,17 @@ #define TEST_OPERATOR(a, b, op, fmt) \ do { \ - __auto_type _a = (a); \ - __auto_type _b = (b); \ - if (!(_a op _b)) { \ - ccprintf("%d: ASSERSION failed: %s " #op " %s\n", \ - __LINE__, #a, #b); \ - ccprintf("\t\tEVAL: " fmt " " #op " " fmt "\n", \ - _a, _b); \ + __auto_type _a = (a); \ + __auto_type _b = (b); \ + if (!(_a op _b)) { \ + ccprintf("%d: ASSERSION failed: %s " #op " %s\n", \ + __LINE__, #a, #b); \ + ccprintf("\t\tEVAL: " fmt " " #op " " fmt "\n", \ + _a, _b); \ task_dump_trace(); \ return EC_ERROR_UNKNOWN; \ + } else { \ + ccprintf("Pass: %s " #op " %s\n", #a, #b); \ } \ } while (0) |