diff options
| author | Diana Z <dzigterman@chromium.org> | 2020-01-27 15:41:19 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-01-28 19:29:46 +0000 |
| commit | d9a869beb6e1778cec38dcce64f289aba353a8d5 (patch) | |
| tree | ba81ea9e865daaf4b97a57e76ff1e9ab6aa7faf9 | |
| parent | bfbfd07131e2d21fd0d8359c6f7e8040927e27ae (diff) | |
| download | chrome-ec-d9a869beb6e1778cec38dcce64f289aba353a8d5.tar.gz | |
TCPMv2: Ensure Rd is set in Debug Accessory.SNK
When tcpm_init() runs (ex. during a phy layer reset), it will cache an
Open state for the CC pull. This can cause Open to be presented on the
CC lines during the next call to set polarity. The Attached.SNK state
already ensures Rd is set by calling set_cc explicitly, and this change
adds an explicit set to Rd for Debug Accessory.SNK as well.
BRANCH=None
BUG=b:147316570
TEST=loaded on waddledoo, ensured CC lines weren't set to Open when
suzy-q was plugged in
Change-Id: I17ea735632e10c666691c04d56057c57688dcbd6
Signed-off-by: Diana Z <dzigterman@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2023240
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
| -rw-r--r-- | common/usbc/usb_tc_drp_acc_trysrc_sm.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/common/usbc/usb_tc_drp_acc_trysrc_sm.c b/common/usbc/usb_tc_drp_acc_trysrc_sm.c index 5e7fd25319..25d0096dc7 100644 --- a/common/usbc/usb_tc_drp_acc_trysrc_sm.c +++ b/common/usbc/usb_tc_drp_acc_trysrc_sm.c @@ -2245,6 +2245,8 @@ static void tc_dbg_acc_snk_entry(const int port) CAP_DUALROLE : CAP_DEDICATED); } } + /* Apply Rd */ + tcpm_set_cc(port, TYPEC_CC_RD); /* Enable PD */ tc[port].pd_enable = 1; |