diff options
| author | ben.chen2@quanta.corp-partner.google.com <ben.chen2@quanta.corp-partner.google.com> | 2019-10-04 13:58:58 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-10-14 04:31:40 +0000 |
| commit | fd6c12c25cfb45db4b6366d137a84afd4612cfbd (patch) | |
| tree | 04b58e2dae019256932cccd4d9a31601957e8d3b | |
| parent | 57eac6b37e1565bad779ef8fa7cdd77085f489a1 (diff) | |
| download | chrome-ec-fd6c12c25cfb45db4b6366d137a84afd4612cfbd.tar.gz | |
Kled: fix rotation matrices of lid sensors
Has a set lid sensors place change.The rotation of lid
matrices need to be fixed.
BUG=b:142029194
BRANCH=Master
TEST=Using ec console 'accelinfo on' verified lid angle now goes
from 0 to 360 and swtiches to tablet mode after crossing 180 threshold.
Change-Id: I0cc5ef07368366f9a645fa44fa29cceec5181539
Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1839712
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Philip Chen <philipchen@chromium.org>
| -rw-r--r-- | board/kindred/board.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/board/kindred/board.c b/board/kindred/board.c index 2157deb4b7..3a8d0da7cd 100644 --- a/board/kindred/board.c +++ b/board/kindred/board.c @@ -189,15 +189,10 @@ static const mat33_fp_t base_standard_ref = { { 0, 0, FLOAT_TO_FP(1)} }; -/* - * TODO(b/124337208): P0 boards don't have this sensor mounted so the rotation - * matrix can't be tested properly. This needs to be revisited after EVT to make - * sure the rotaiton matrix for the lid sensor is correct. - */ static const mat33_fp_t lid_standard_ref = { - { 0, FLOAT_TO_FP(-1), 0}, { FLOAT_TO_FP(-1), 0, 0}, - { 0, 0, FLOAT_TO_FP(-1)} + { 0, FLOAT_TO_FP(-1), 0}, + { 0, 0, FLOAT_TO_FP(1)} }; struct motion_sensor_t motion_sensors[] = { |