diff options
| author | Patrick Georgi <pgeorgi@google.com> | 2019-09-02 14:11:04 +0200 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-09-04 11:53:25 +0000 |
| commit | fa3ddd11c3084916e8836f8eeda4e8daad836836 (patch) | |
| tree | 6506a3589cc60b359c54042f61d75a61d40a89e6 | |
| parent | d394166abbeb067e650417028569c96bc390d71c (diff) | |
| download | chrome-ec-fa3ddd11c3084916e8836f8eeda4e8daad836836.tar.gz | |
util/comm-i2c: Fix memory leak
Found by Coverity #58167
BUG=none
BRANCH=none
TEST=none
Change-Id: I434d4b140683b4c3440c30b232fab34d781da9d4
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1781466
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Commit-Queue: Patrick Georgi <pgeorgi@chromium.org>
| -rw-r--r-- | util/comm-i2c.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/util/comm-i2c.c b/util/comm-i2c.c index bc2684f3da..ea2ca7c94e 100644 --- a/util/comm-i2c.c +++ b/util/comm-i2c.c @@ -174,11 +174,11 @@ int comm_init_i2c(void) { char *file_path; char buffer[64]; - FILE *f; int i; /* find the device number based on the adapter name */ for (i = 0; i < I2C_MAX_ADAPTER; i++) { + FILE *f; if (asprintf(&file_path, I2C_ADAPTER_NODE, i, i, EC_I2C_ADDR) < 0) return -1; @@ -187,6 +187,7 @@ int comm_init_i2c(void) if (fgets(buffer, sizeof(buffer), f) && !strncmp(buffer, I2C_ADAPTER_NAME, 6)) { free(file_path); + fclose(f); break; } fclose(f); |