summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Georgi <pgeorgi@google.com>2019-09-02 13:44:16 +0200
committerCommit Bot <commit-bot@chromium.org>2019-09-04 11:53:23 +0000
commitd394166abbeb067e650417028569c96bc390d71c (patch)
tree28553552f22335840f25f6f4eb4afaf1b9d8a7b7
parent350193684430b379d1ad76220683de8956e89286 (diff)
downloadchrome-ec-d394166abbeb067e650417028569c96bc390d71c.tar.gz
common/mkbp_event: Avoid accessing an uninitialized variable
Found by Coverity Scan #198896 BUG=none BRANCH=none TEST=none Change-Id: I0f606e49ed30ff15054c296a8e698aca68a955d3 Signed-off-by: Patrick Georgi <pgeorgi@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1781465 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Patrick Georgi <pgeorgi@chromium.org> Commit-Queue: Patrick Georgi <pgeorgi@chromium.org>
-rw-r--r--common/mkbp_event.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/common/mkbp_event.c b/common/mkbp_event.c
index 12a439241b..32169d24e3 100644
--- a/common/mkbp_event.c
+++ b/common/mkbp_event.c
@@ -316,10 +316,12 @@ static int take_event_if_set(uint8_t event_type)
static int mkbp_get_next_event(struct host_cmd_handler_args *args)
{
static int last;
- int i, data_size, evt;
+ int i, evt;
uint8_t *resp = args->response;
const struct mkbp_event_source *src;
+ int data_size = -EC_ERROR_BUSY;
+
do {
/*
* Find the next event to service. We do this in a round-robin