summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Georgi <pgeorgi@google.com>2019-09-02 17:12:31 +0200
committerCommit Bot <commit-bot@chromium.org>2019-09-04 11:53:28 +0000
commit43d6a36faa96b7a63a8779906272078dc9161e91 (patch)
tree687f3fecc57d5c79d1efddda9f0f6a6658dfc1ec
parentb677e67afb50e67fa30cb7673a7bb5947c54ce57 (diff)
downloadchrome-ec-43d6a36faa96b7a63a8779906272078dc9161e91.tar.gz
util/iteflash: Close file on error path
Found by Coverity Scan #58166 BUG=none TEST=none BRANCH=none Change-Id: I1caa2a407a2c623c006c500a56c7048649ebb158 Signed-off-by: Patrick Georgi <pgeorgi@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1781470 Tested-by: Patrick Georgi <pgeorgi@chromium.org> Commit-Queue: Patrick Georgi <pgeorgi@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
-rw-r--r--util/iteflash.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/util/iteflash.c b/util/iteflash.c
index 68e4b34862..fd83980c77 100644
--- a/util/iteflash.c
+++ b/util/iteflash.c
@@ -1502,6 +1502,7 @@ static int write_flash(struct common_hnd *chnd, const char *filename,
fprintf(stderr, "%s: Failed to read %d bytes from %s with "
"ferror() %d\n", __func__, size, filename, ferror(hnd));
free(buffer);
+ fclose(hnd);
return -EIO;
}
fclose(hnd);