diff options
| author | Yilun Lin <yllin@google.com> | 2019-01-17 17:09:41 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-01-19 00:13:52 -0800 |
| commit | a1269ed29a92f79f47732686112192148295d85d (patch) | |
| tree | 7a27e22be00dd4399cc37f15e1043778d83ffa9f | |
| parent | b81b644c86f6c4d1f802cd7f132d80085d2ddc90 (diff) | |
| download | chrome-ec-a1269ed29a92f79f47732686112192148295d85d.tar.gz | |
kukui: Fix adc read crashes EC.
The ADC module is diabled after reading the BOARD_ID on system booted.
This will hang the adc reading once we commanding "adc" to EC after
that, and thus triggers wathdog.
TEST=BOOTBLOCK=... make BOARD=kukui -j flash_ec.
See AP booted; type "adc" in EC console, and see that it won't
trigger watchdog.
BRANCH=None
BUG=b:122995670
Change-Id: Id13d6ceddf74a06b741ab0c834c75409ab580c74
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1416074
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
| -rw-r--r-- | board/kukui/board.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/board/kukui/board.c b/board/kukui/board.c index adabd38ef9..102aab1c92 100644 --- a/board/kukui/board.c +++ b/board/kukui/board.c @@ -311,14 +311,6 @@ int board_get_version(void) } } - /* - * Disable ADC module after we detect the board version, - * since this is the only thing ADC module needs to do - * for this board. - */ - if (version != BOARD_VERSION_UNKNOWN) - adc_disable(); - return version; } |