diff options
| author | Rob Barnes <robbarnes@google.com> | 2022-05-11 08:37:52 -0600 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-05-11 18:27:42 +0000 |
| commit | c8438c23ba0e458acf099a802ebc34cc1cb81555 (patch) | |
| tree | 20c1d00038c94542084a532d61a68ada3bfc5ab7 | |
| parent | 16bf008d43c1d297e62d49e4cbd060cfa5df1745 (diff) | |
| download | chrome-ec-c8438c23ba0e458acf099a802ebc34cc1cb81555.tar.gz | |
guybrush: Enable i2c PEC for battery fuel gauge
The fuel gauge could NACK during a read operation and then return
invalid data. The only way to detect this corruption is to enable PEC.
The config enables PEC globally, but the smart battery is the only
driver that sets the I2C_FLAG_PEC flag, so this change will only affect
the smart battery.
BUG=b:230520109
BRANCH=guybrush
TEST=Boot nipperkin, no errors observed, battery status is correct
Change-Id: I50e60350ccff7e58f170c24921bc442eea0af817
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3641481
Commit-Queue: Robert Zieba <robertzieba@google.com>
Reviewed-by: Robert Zieba <robertzieba@google.com>
| -rw-r--r-- | baseboard/guybrush/baseboard.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/baseboard/guybrush/baseboard.h b/baseboard/guybrush/baseboard.h index 513c104743..9e4cdc8f1e 100644 --- a/baseboard/guybrush/baseboard.h +++ b/baseboard/guybrush/baseboard.h @@ -155,6 +155,8 @@ #define CONFIG_BATTERY_COUNT 1 #define CONFIG_HOSTCMD_BATTERY_V2 #define CONFIG_BC12_DETECT_PI3USB9201 +/* Enable PEC to detect potential corruption on read (b/230520109) */ +#define CONFIG_SMBUS_PEC /* Charger Config */ #define CONFIG_CHARGER |