diff options
| author | Gwendal Grignou <gwendal@chromium.org> | 2021-01-28 13:46:25 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-01-29 18:20:35 +0000 |
| commit | 0438e061c30640f4d72213fd09f2f8ba334c22ae (patch) | |
| tree | 9494b5274f142024c0b4e1b76a489b74d40146c4 | |
| parent | 72f093ad007a3e706056d2acabac854d2d2f085f (diff) | |
| download | chrome-ec-0438e061c30640f4d72213fd09f2f8ba334c22ae.tar.gz | |
driver: icm426xx: Use calibration unit to set/get offset
EC interface use constant (not range dependent) units to get/set
offsets. Use them in icm426xx driver.
BUG=b:177292639
BRANCH=hatch,nami,kukui,dedede,grunt,zork,octopus,volteer
TEST=compile
Change-Id: I6e6b1551464ea389db34646ba5b2bb553d683d7a
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2657955
Reviewed-by: Ching-Kang Yen <chingkang@chromium.org>
Reviewed-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
| -rw-r--r-- | driver/accelgyro_icm426xx.c | 33 |
1 files changed, 13 insertions, 20 deletions
diff --git a/driver/accelgyro_icm426xx.c b/driver/accelgyro_icm426xx.c index 6649b43c2a..77867ed722 100644 --- a/driver/accelgyro_icm426xx.c +++ b/driver/accelgyro_icm426xx.c @@ -658,27 +658,24 @@ out_unlock: static int icm426xx_set_offset(const struct motion_sensor_t *s, const int16_t *offset, int16_t temp) { - struct accelgyro_saved_data_t *data = ICM_GET_SAVED_DATA(s); intv3_t v = { offset[X], offset[Y], offset[Z] }; int div1, div2; int i; - /* unscale values and rotate back to chip frame */ - for (i = X; i <= Z; ++i) - v[i] = SENSOR_APPLY_DIV_SCALE(v[i], data->scale[i]); + /* rotate back to chip frame */ rotate_inv(v, *s->rot_standard_ref, v); /* convert raw data to hardware offset units */ switch (s->type) { case MOTIONSENSE_TYPE_ACCEL: - /* hardware offset is 1/2048g by LSB */ - div1 = s->current_range * 2048; - div2 = 32768; + /* hardware offset is 1/2048g /LSB, EC offset 1/1024g /LSB. */ + div1 = 2; + div2 = 1; break; case MOTIONSENSE_TYPE_GYRO: - /* hardware offset is 1/32dps by LSB */ - div1 = s->current_range * 32; - div2 = 32768; + /* hardware offset is 1/32dps /LSB, EC offset 1/1024dps /LSB. */ + div1 = 1; + div2 = 32; break; default: return EC_ERROR_INVAL; @@ -692,7 +689,6 @@ static int icm426xx_set_offset(const struct motion_sensor_t *s, static int icm426xx_get_offset(const struct motion_sensor_t *s, int16_t *offset, int16_t *temp) { - struct accelgyro_saved_data_t *data = ICM_GET_SAVED_DATA(s); intv3_t v; int div1, div2; int i, ret; @@ -704,14 +700,14 @@ static int icm426xx_get_offset(const struct motion_sensor_t *s, int16_t *offset, /* transform offset to raw data */ switch (s->type) { case MOTIONSENSE_TYPE_ACCEL: - /* hardware offset is 1/2048g by LSB */ - div1 = 32768; - div2 = 2048 * s->current_range; + /* hardware offset is 1/2048g /LSB, EC offset 1/1024g /LSB. */ + div1 = 1; + div2 = 2; break; case MOTIONSENSE_TYPE_GYRO: - /* hardware offset is 1/32dps by LSB */ - div1 = 32768; - div2 = 32 * s->current_range; + /* hardware offset is 1/32dps /LSB, EC offset 1/1024dps /LSB. */ + div1 = 32; + div2 = 1; break; default: return EC_ERROR_INVAL; @@ -720,9 +716,6 @@ static int icm426xx_get_offset(const struct motion_sensor_t *s, int16_t *offset, v[i] = round_divide(v[i] * div1, div2); rotate(v, *s->rot_standard_ref, v); - for (i = X; i <= Z; i++) - v[i] = SENSOR_APPLY_SCALE(v[i], data->scale[i]); - offset[X] = v[X]; offset[Y] = v[Y]; offset[Z] = v[Z]; |