diff options
| author | Patryk Duda <pdk@semihalf.com> | 2020-08-28 12:53:47 +0200 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-05-01 21:29:08 +0000 |
| commit | f340538c23a6b4b5ccc2ed0112bd366dac2f4134 (patch) | |
| tree | 7861855020707d5377d67f8c6213e9c9851e4b1f | |
| parent | 8dfc831d80009850a8b5061c5dae0e1698544805 (diff) | |
| download | chrome-ec-f340538c23a6b4b5ccc2ed0112bd366dac2f4134.tar.gz | |
npcx/system: Use newly provided functions to access panic data
This change removes usage of PANIC_DATA_PTR where possible. Now panic
data is accessed through functions that performs more checks and in case
of writing also moves other data when necessary.
BUG=b:165773837, b:162254118
BRANCH=none
TEST=make -j buildall
Signed-off-by: Patryk Duda <pdk@semihalf.com>
Change-Id: I83dacf1bf680f15a8d5ce3dbb30b03fc3cc54f48
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2379848
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4455293
Commit-Queue: Rob Barnes <robbarnes@google.com>
Tested-by: Rob Barnes <robbarnes@google.com>
Reviewed-by: Boris Mittelberg <bmbm@google.com>
| -rw-r--r-- | chip/npcx/system.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/chip/npcx/system.c b/chip/npcx/system.c index 0ae6aac009..e6885177b0 100644 --- a/chip/npcx/system.c +++ b/chip/npcx/system.c @@ -287,7 +287,7 @@ void chip_panic_data_backup(void) static void chip_panic_data_restore(void) { - struct panic_data *d = PANIC_DATA_PTR; + struct panic_data *d; /* Ensure BBRAM is valid. */ if (!bbram_valid(BKUP_MMFS, 4)) @@ -298,9 +298,11 @@ static void chip_panic_data_restore(void) BKUP_PANIC_DATA_VALID)) return; - memset(d, 0, sizeof(*d)); + d = get_panic_data_write(); + + memset(d, 0, CONFIG_PANIC_DATA_SIZE); d->magic = PANIC_DATA_MAGIC; - d->struct_size = sizeof(*d); + d->struct_size = CONFIG_PANIC_DATA_SIZE; d->struct_version = 2; d->arch = PANIC_ARCH_CORTEX_M; |