summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDevin Lu <devin.lu@quantatw.com>2019-04-16 12:31:44 +0800
committerChromeOS Commit Bot <chromeos-commit-bot@chromium.org>2019-04-19 15:44:48 +0000
commitd84f6d6cdd6e14e88ffcd346837d371e37970f45 (patch)
treeacda0d612c80596fbeee634f922f98d61d64ced1
parent08a8cd0b63fab7baacec4b4b5ca28584456ce3c3 (diff)
downloadchrome-ec-d84f6d6cdd6e14e88ffcd346837d371e37970f45.tar.gz
bloog: Disable ec_feature kbbacklit by SKUID
Remove kbbacklight support with non-kbbacklight SKU. BUG=b:130142249, b:129397770 BRANCH=octopus TEST=make sure ectool inventory doesn't show keyboard backlight support with non-kbbacklight SKU. Change-Id: I820f13fb13c58b63492a6e544e22545e8ee65f4c Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/1568893 Commit-Ready: Marco Chen <marcochen@chromium.org> Reviewed-by: Marco Chen <marcochen@chromium.org> (cherry picked from commit 8bd447af96dcbf7d714ad23f65835d09332fcfc1) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1575047 Commit-Queue: Marco Chen <marcochen@chromium.org>
-rw-r--r--board/bloog/board.c16
-rw-r--r--board/bloog/board.h2
2 files changed, 18 insertions, 0 deletions
diff --git a/board/bloog/board.c b/board/bloog/board.c
index 73bec21045..498eee17bd 100644
--- a/board/bloog/board.c
+++ b/board/bloog/board.c
@@ -300,3 +300,19 @@ void board_overcurrent_event(int port, int is_overcurrented)
/* Note that the level is inverted because the pin is active low. */
gpio_set_level(GPIO_USB_C_OC, !is_overcurrented);
}
+
+uint32_t board_override_feature_flags0(uint32_t flags0)
+{
+ /*
+ * Remove keyboard backlight feature for devices that don't support it.
+ */
+ if (sku_id == 33)
+ return (flags0 & ~EC_FEATURE_MASK_0(EC_FEATURE_PWM_KEYB));
+ else
+ return flags0;
+}
+
+uint32_t board_override_feature_flags1(uint32_t flags1)
+{
+ return flags1;
+}
diff --git a/board/bloog/board.h b/board/bloog/board.h
index 6dc9586a73..05a56d0214 100644
--- a/board/bloog/board.h
+++ b/board/bloog/board.h
@@ -24,6 +24,8 @@
#define CONFIG_LED_COMMON
#define OCTOPUS_POWER_LED
+#define CONFIG_EC_FEATURE_BOARD_OVERRIDE
+
/* Sensors */
#define CONFIG_ACCEL_KX022 /* Lid accel */
#define CONFIG_ACCELGYRO_LSM6DSM /* Base accel */