diff options
| author | Patrick Georgi <pgeorgi@google.com> | 2018-07-26 12:18:41 +0200 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2018-11-30 18:33:26 +0000 |
| commit | fce0596723211ce7e7a50f3663e14c2a23c8e137 (patch) | |
| tree | 55455857b152705eb0fe82260183a73d0f3b8bfe | |
| parent | 9ecae23d3498ec4b80505f14d7d6245c50cf564a (diff) | |
| download | chrome-ec-fce0596723211ce7e7a50f3663e14c2a23c8e137.tar.gz | |
util/cbi-util: Check pointer before using it
Change-Id: If11de8883b001f16d7e8f859a416fbdc5ea0391a
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Found-by: Coverity Scan #187038
Reviewed-on: https://chromium-review.googlesource.com/1151121
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1355373
Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
| -rw-r--r-- | util/cbi-util.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/util/cbi-util.c b/util/cbi-util.c index 5db416fbe4..23d9986348 100644 --- a/util/cbi-util.c +++ b/util/cbi-util.c @@ -333,11 +333,13 @@ static void print_integer(const uint8_t *buf, enum cbi_data_tag tag) { uint32_t v; struct cbi_data *d = cbi_find_tag(buf, tag); - const char *name = d->tag < CBI_TAG_COUNT ? field_name[d->tag] : "???"; + const char *name; if (!d) return; + name = d->tag < CBI_TAG_COUNT ? field_name[d->tag] : "???"; + switch (d->size) { case 1: v = *(uint8_t *)d->value; |