summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaisuke Nojiri <dnojiri@chromium.org>2019-05-14 19:16:28 -0700
committerCommit Bot <commit-bot@chromium.org>2019-05-23 16:43:06 +0000
commit18ba151297512db7673ea65436b9250262a971f4 (patch)
treee72460395bc06c0a1d0b068b12fbb0c29faa5810
parent6efb58b52acad97cf890ce1a22e4f03717f56b18 (diff)
downloadchrome-ec-18ba151297512db7673ea65436b9250262a971f4.tar.gz
pi3usb9281: Mask OVP, OCP, and recovery interrupts
Currently, we're handling only attach and detach interrupt and OVP recovery interrupt causes us to miss detach & attach events. This patch masks all unused interrupts. Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> BUG=b/125176293 BRANCH=none TEST=See b/125176293 Change-Id: I8387b96abdc073e608b6373b670cbb684b342736 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1626315 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
-rw-r--r--driver/bc12/pi3usb9281.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/driver/bc12/pi3usb9281.c b/driver/bc12/pi3usb9281.c
index 0c43bb199b..ee7f81433d 100644
--- a/driver/bc12/pi3usb9281.c
+++ b/driver/bc12/pi3usb9281.c
@@ -151,15 +151,15 @@ static void pi3usb9281_init(int port)
CPRINTS("PI3USB9281 invalid ID 0x%02x", dev_id);
pi3usb9281_reset(port);
- pi3usb9281_set_interrupt_mask(port, 0xff);
pi3usb9281_enable_interrupts(port);
}
int pi3usb9281_enable_interrupts(int port)
{
- uint8_t ctrl = pi3usb9281_read(port, PI3USB9281_REG_CONTROL);
-
+ uint8_t ctrl;
+ pi3usb9281_set_interrupt_mask(port, PI3USB9281_INT_ATTACH_DETACH);
+ ctrl = pi3usb9281_read(port, PI3USB9281_REG_CONTROL);
if (ctrl == 0xee)
return EC_ERROR_UNKNOWN;