diff options
| author | Sam Hurst <shurst@google.com> | 2022-05-25 10:24:54 -0700 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-05-31 17:12:46 +0000 |
| commit | b74732a30acdca34f25c3afb17921637406db14d (patch) | |
| tree | 83cffa4985eddec071cb7dedd93ceed7182adf7f | |
| parent | 4e012fd31e03507c4b254e49825e0dfbf263a375 (diff) | |
| download | chrome-ec-b74732a30acdca34f25c3afb17921637406db14d.tar.gz | |
ec: Change EC_SPI_RX_READY host command
The EC_SPI_RX_READY macro has been changed so that MSB
is low if it is placed on the SDO lin when the CS goes low.
BUG=b:216831450
BRANCH=none
TEST=zmake testall
Verified on scope that SHI_SDO does not pulse high
during AP Shutdown
Signed-off-by: Sam Hurst <shurst@google.com>
Change-Id: I851633855e1c2bcb91f98ca81612cbdea8330ee0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3668647
Reviewed-by: Wai-Hong Tam <waihong@google.com>
| -rw-r--r-- | include/ec_commands.h | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/include/ec_commands.h b/include/ec_commands.h index b8d6ff3328..f43ad24e06 100644 --- a/include/ec_commands.h +++ b/include/ec_commands.h @@ -829,11 +829,15 @@ struct ec_lpc_host_args { #define EC_SPI_PAST_END 0xed /* - * EC is ready to receive, and has ignored the byte sent by the AP. EC expects + * EC is ready to receive, and has ignored the byte sent by the AP. EC expects * that the AP will send a valid packet header (starting with * EC_COMMAND_PROTOCOL_3) in the next 32 bytes. + * + * NOTE: Some SPI configurations place the Most Significant Bit on SDO when + * CS goes low. This macro has the Most Significant Bit set to zero, + * so SDO will not be driven high when CS goes low. */ -#define EC_SPI_RX_READY 0xf8 +#define EC_SPI_RX_READY 0x78 /* * EC has started receiving the request from the AP, but hasn't started |