diff options
| author | Caveh Jalali <caveh@chromium.org> | 2020-01-13 20:19:47 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-07-16 16:20:31 +0000 |
| commit | 10541fe4c71f0c0f44919abe96a7a54154121aee (patch) | |
| tree | 8b2dc5047e8d69ad13583547b5150d3eefef18ed | |
| parent | 3f205275779439c30fd7710af402eca24e329350 (diff) | |
| download | chrome-ec-10541fe4c71f0c0f44919abe96a7a54154121aee.tar.gz | |
syv682x: fix status register read
We were reading CONTROL_1_REG instead of STATUS_REG to check the
VSAFE_0V status. This corrects the register being accessed.
BRANCH=none
BUG=none
TEST=volteer boots without a battery
Change-Id: I06d0fbc0b9313b809ed43be13138241beca395a5
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1999619
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Scott Collyer <scollyer@chromium.org>
Commit-Queue: Scott Collyer <scollyer@chromium.org>
(cherry picked from commit d9d96d1b01cb66fbfdc50fe705eaa2cc2579b442)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2291467
Tested-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
| -rw-r--r-- | driver/ppc/syv682x.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/driver/ppc/syv682x.c b/driver/ppc/syv682x.c index 5f80dd3d90..22222e59ba 100644 --- a/driver/ppc/syv682x.c +++ b/driver/ppc/syv682x.c @@ -302,11 +302,14 @@ static int syv682x_init(int port) return rv; /* Check if this if dead battery case */ - rv = read_reg(port, SYV682X_CONTROL_1_REG, ®val); + rv = read_reg(port, SYV682X_STATUS_REG, ®val); if (rv) return rv; if (regval & SYV682X_STATUS_VSAFE_0V) { /* Not dead battery case, so disable channel */ + rv = read_reg(port, SYV682X_CONTROL_1_REG, ®val); + if (rv) + return rv; regval |= SYV682X_CONTROL_1_PWR_ENB; rv = write_reg(port, SYV682X_CONTROL_1_REG, regval); if (rv) |