summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJon Murphy <jpmurphy@google.com>2022-05-20 11:27:41 -0600
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>2022-05-20 20:23:37 +0000
commitf348b3bfe2adb76a07489633db77e5e9f42a9985 (patch)
tree5d2bb36e465b5d61534202e92d1a7cb5cb8e9ae0
parent01e38f0318ad345ed46c59a5646981bf25ac9a88 (diff)
downloadchrome-ec-f348b3bfe2adb76a07489633db77e5e9f42a9985.tar.gz
MonkeyIsland: Remove resolved TODO's
A number of TODO's are still in our code base, but have been resolved. Remove them. BUG=b:232952508 BRANCH=guybrush TEST=N/A Signed-off-by: Jon Murphy <jpmurphy@google.com> Change-Id: Ie2d2705ae546b10cded2f4612ef68a1f8aeedc67 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3656818 Reviewed-by: Diana Z <dzigterman@chromium.org> Reviewed-by: Rob Barnes <robbarnes@google.com>
-rw-r--r--baseboard/guybrush/baseboard.h1
-rw-r--r--board/dewatt/board.c5
-rw-r--r--board/guybrush/board.c5
-rw-r--r--board/nipperkin/board.c5
4 files changed, 0 insertions, 16 deletions
diff --git a/baseboard/guybrush/baseboard.h b/baseboard/guybrush/baseboard.h
index 9e4cdc8f1e..a324a41916 100644
--- a/baseboard/guybrush/baseboard.h
+++ b/baseboard/guybrush/baseboard.h
@@ -226,7 +226,6 @@
#define CONFIG_IO_EXPANDER_NCT38XX
#define CONFIG_IO_EXPANDER_PORT_COUNT USBC_PORT_COUNT
-/* TODO(b/176988382): Tune values for guybrush */
#define PD_POWER_SUPPLY_TURN_ON_DELAY 30000 /* us */
#define PD_POWER_SUPPLY_TURN_OFF_DELAY 30000 /* us */
diff --git a/board/dewatt/board.c b/board/dewatt/board.c
index 3f02cf2d03..8d37cd076d 100644
--- a/board/dewatt/board.c
+++ b/board/dewatt/board.c
@@ -177,11 +177,6 @@ board_a1_ps8811_retimer_init(const struct usb_mux *me)
return EC_SUCCESS;
}
-/*
- * PS8818 set mux board tuning.
- * Adds in board specific gain and DP lane count configuration
- * TODO(b/179036200): Adjust PS8818 tuning for guybrush reference
- */
__override int board_c1_ps8818_mux_set(const struct usb_mux *me,
mux_state_t mux_state)
{
diff --git a/board/guybrush/board.c b/board/guybrush/board.c
index 922be3ca21..6ba8de04c9 100644
--- a/board/guybrush/board.c
+++ b/board/guybrush/board.c
@@ -221,11 +221,6 @@ board_a1_ps8811_retimer_init(const struct usb_mux *me)
return EC_SUCCESS;
}
-/*
- * PS8818 set mux board tuning.
- * Adds in board specific gain and DP lane count configuration
- * TODO(b/179036200): Adjust PS8818 tuning for guybrush reference
- */
__override int board_c1_ps8818_mux_set(const struct usb_mux *me,
mux_state_t mux_state)
{
diff --git a/board/nipperkin/board.c b/board/nipperkin/board.c
index 432eb06e79..93db38b7ec 100644
--- a/board/nipperkin/board.c
+++ b/board/nipperkin/board.c
@@ -62,11 +62,6 @@ board_a1_ps8811_retimer_init(const struct usb_mux *me)
return EC_SUCCESS;
}
-/*
- * PS8818 set mux board tuning.
- * Adds in board specific gain and DP lane count configuration
- * TODO(b/179036200): Adjust PS8818 tuning for guybrush reference
- */
__override int board_c1_ps8818_mux_set(const struct usb_mux *me,
mux_state_t mux_state)
{