diff options
| author | Bobby Casey <bobbycasey@google.com> | 2023-04-21 00:30:50 -0400 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-05-08 19:40:54 +0000 |
| commit | e107a850e01b762d2757a34936b19f961580fcca (patch) | |
| tree | aac85658fba790481875fca65f36708c9d14de2c | |
| parent | bde86e6530fbe9350ed9f8d5273083c3100510f6 (diff) | |
| download | chrome-ec-e107a850e01b762d2757a34936b19f961580fcca.tar.gz | |
flash_ec: Fix shellcheck warning SC2295
The failure was:
[FAILED] chromiumos/platform/ec: cros lint
Hook script "cros lint ${PRESUBMIT_FILES}" failed with code 1:
In util/flash_ec line 798:
save=( "${CTRL_RESULT#${DUT_CTRL_PREFIX}}" "${save[@]}" )
^----------------^
SC2295 (info): Expansions inside ${..} need to be quoted separately,
otherwise they match as patterns.
Did you mean:
save=( "${CTRL_RESULT#"${DUT_CTRL_PREFIX}"}" "${save[@]}" )
BRANCH=none
BUG=b:242127759
TEST=util/flash_ec --board=dartmonkey --image build/dartmonkey/ec.bin
Change-Id: I92bb0aa609be5e377e7ad04f64b81533b3ca9363
Signed-off-by: Bobby Casey <bobbycasey@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4455231
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
| -rwxr-xr-x | util/flash_ec | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/util/flash_ec b/util/flash_ec index 7626203674..bc09c4c9c2 100755 --- a/util/flash_ec +++ b/util/flash_ec @@ -794,7 +794,7 @@ function servo_save_add() { # Don't save the control with the prefix, because # dut_control will add the prefix again when we restore # the settings. - save=( "${CTRL_RESULT#${DUT_CTRL_PREFIX}}" "${save[@]}" ) + save=( "${CTRL_RESULT#"${DUT_CTRL_PREFIX}"}" "${save[@]}" ) fi ;; 2) save=( "$1:$2" "${save[@]}" ) |